A hook is needed to invoke per-attachment functionality. Probably best to use a Hook.process("row") in template/en/default/attachment/list.html.tmpl just after the "Edit" and "Diff" links.
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.22
What kind of functionality is being invoked?
Created attachment 186345 [details] [diff] [review] Adding a hook for custom actions on attachments With exception of the hook name "row" -> "action"
myk: There are other (local) functions that act on an attachment to push it out through a release mechanism. I can see this also being useful to invoke a variety of other viewing tools that a site may have.
Comment on attachment 186345 [details] [diff] [review] Adding a hook for custom actions on attachments Ah, ok, that makes sense. It just wasn't clear initially that the purpose of the hook was to add actions. It seemed perhaps it was for adding additional columns to the table or performing some other task (in which case the hook might have been better placed in another part of the template). This looks good to me, except that it should be indented one more space.
Attachment #186345 - Flags: review+
Comment on attachment 186345 [details] [diff] [review] Adding a hook for custom actions on attachments I'll fix the space on checkin.
Hooks can go into the next available release, even during a freeze. a=myk for checkin to 2.20.
Flags: approval? → approval+
Target Milestone: Bugzilla 2.22 → Bugzilla 2.20
Checking in template/en/default/attachment/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v <-- list.html.tmpl new revision: 1.21; previous revision: 1.20 done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(In reply to comment #5) > (From update of attachment 186345 [details] [diff] [review] ) > I'll fix the space on checkin. > Filed one more bug for mozilla.org product to help eliminate that tabs in templates. See bug 297891
You need to log in before you can comment on or make changes to this bug.