297808 - <output> data not updating

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Stephen Pride]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050615 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050615 Firefox/1.0+

Sorry if the summary is vague - I'll try to explain.

Go to the URL above using Mozila w/XForms.  Click on the "Stock order form (for
other XForms browsers)" link.  You should get a popup followed by another popup.
 A Stock order example page should then apear.  Enter a stock symbol (it doesn't
matter what).  Once focus is lost for the input control, an xforms-value-changed
event is fired which causes a submission to a remote web site to get some data.
 The data should come back and populate the <xf:output> controls.  In the status
bar of the browser, it shows data is being transferred to the remote site.

If the same is done using IE with formsPlayer and clicking on the example "Stock
order form (for formsPlayer)", the output is displayed properly.

Reproducible: Always

Actual Results:  
No data is displayed after a stock symbol is entered and focus is lost on the
input control.

Expected Results:  
User should the stock symbol information displayed after a stock symbol is
entered and focus is lost on the input control.

Comment 1

[aaronr]

The problem here is that instance replacement isn't working right.  This form
does a submission with instance replacement and the output is bound to this
instance so that when the data is returned, the output should be updated with
the result.  However our instance replacement only replaces instance in the
first instance document rather than the proper nodeset in the proper instance
document.

Comment 2

[aaronr]

Attachment: testcase

This is a simplified testcase.	If you click on the first trigger, let the
submission return and then click on the second trigger, you should see an
updated instance document with an IBM stock quote.

Comment 3

[aaronr]

Attachment: first attempt

pretty simple fix.  Just find the instance element that holds the data this
submission is bound to and replace its document with the document we got from
the submission.

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 186455 [details] [diff] [review]
first attempt

looks fine

Comment 5

[Allan Beaufour]

Comment on attachment 186455 [details] [diff] [review]
first attempt

>+  nsresult rv = GetSelectedInstanceData(getter_AddRefs(data));
>+  if (NS_SUCCEEDED(rv)) {

Why do we rebuild, etc. if GetSelectedInstanceData() fails?

>+    nsCOMPtr<nsIDOMNode> instanceNode;
>+    rv = nsXFormsUtils::GetInstanceNodeForData(data, model, getter_AddRefs(instanceNode));

Split line.

>+    NS_ENSURE_SUCCESS(rv, rv);
> 
>-  instance->SetDocument(newDoc);
>+    nsCOMPtr<nsIInstanceElementPrivate> instanceElement = 

Kill the whitespace at end of the line.

With a good answer to the first question, you have an r=me, but not before.

Comment 6

[aaronr]

Attachment: second attempt

I can't remember why I still refreshed, etc. if I couldn't find the instance to
replace.  So moved that logic inside the test for the instance document.

Comment 7

[aaronr]

Comment on attachment 187475 [details] [diff] [review]
second attempt

Allan must be out on vacation.	Smaug?

Comment 8

[aaronr]

turns out that this patch doesn't work because of the bug fixed by 299283.  Once
299283 is in, this patch will work.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

checked in