29786 - new row isn't the same height

Status: VERIFIED INVALID

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 2/29 build of mozilla

1) launch mozilla
2) launch editor
3) load the above URL
4) insert a new row in this table

notice the new row is not the same heigh as the other rows

all platforms.

Comment 1

[Charles Manske]

Why should it be the same height? A new cell, row, or column is inserted
with the default attributes, which means "autosize" for height and width.
If we copied the height from another row, what about other attributes, such
as color etc? I think it's best to start with a "bland" row and let the user
change the attributes. So let's call this "as designed".

Comment 2

[sujay]

works as designed...verified in 3/1 build.

Comment 3

[Paul MacQuiddy]

I don't know about this, it's not working like 4.x is working, they must have
done some magic. That's why I mentioned it to sujay. Sujay maybe you can look at
the html a little and see what is going on.

Comment 4

[Charles Manske]

Actually, I don't see any difference in height anyway. What do you see?

Comment 5

[Paul MacQuiddy]

when I insert a row in the middle of the table with 4.x, it creates it the same
height as the other rows, which is a bit larger than the default text size. With
seamonkey, it creates it exactly the size of the default text (auto-sizes I
guess). It's not a huge deal, but it seems like 4.x is doing something smarter -
normally you want all your rows doing the same thing, whether it's a fixed
height or autosizing.

Comment 6

[Charles Manske]

Believe me, 4.x is not doing anything "smarter"! It is just subtle differences
in the default (or "auto") height between 4.x and gecko layout.

Comment 7

[Paul MacQuiddy]

I trust you. It's just strange that when I'm in composer, and add a row, the
height is smaller, and text I add in the cells are not centered (alignment is
not inherited also). However, when I save and view in a browser windows,
everything looks fine, and then when I re-open it in composer, it looks fine
also. It's just when I add in composer that things look off. Does that make sense?

Comment 8

[Charles Manske]

Which "Composer" are you referring to? And which "alignment"? In mozilla,
we set valign="top", because the default of "middle" did not seem what most
people want. The valign attribute is the only one we set explicitly - the rest
are "auto"

Comment 9

[Charles Manske]

Actually, I just noticed that it did look like the cell height when you are
initially typing in a new table looked too short, and the text  also seemed to 
overlap the right border by 1 pixel. But clicking on the "Hide Extra Markup"
button at the bottom of the edit window cleared both problems!
We have some CSS like this:
td, tr {
  min-height: 10px;
  min-line-height: 10px;
}
Removing that cures the differences you are seeing. I will remove that CSS 
during M15, since we don't need it anymore, but it is troubling since that
should not have any affect on the display. It is only setting a minimum and
should not have *reduced* the actual height. It should have
made the cell bigger if the normal layout resulted in cell height < 10px.
It's not worth reopening this bug, since the problem will go away with 
my next checkin in M15. 

Comment 10

[sujay]

does this need to bre REOPENED?

Comment 11

[Charles Manske]

As I said above, no.