297871 - [Comments] flagging a comment twice produces an 'error'

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Jon Stritar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

If you try to flag a comment from reportcomment.php when one has already been
flagged, it says:

Error 5: Comment could not be flagged for review. Please go back and try again.

I don't think it should be an error (especially described like that), if someone
tries to flag an already flagged comment. Users can't tell if a comment is
flagged, so they won't know what they are doing wrong. They also don't need to
know if it was already flagged when they flag it- it should act the same way as
when they first flag it. If anyone thinks this is worthy of fixing for 1.1, I
can make a patch.

Reproducible: Always

Steps to Reproduce:
1. Flag a comment.
2. Flag the same comment through reportcomment.php.

Comment 1

[alanjstr]

Flagging a comment should hide it from the public.  The only place it should
appear is the comment review queue.

Comment 2

[Jon Stritar]

It seems like people could get confused by that. Comments would be disappearing
and reappearing all the time. Hiding flagged comments could lead people to think
the comment system is buggy.

Comment 3

[alanjstr]

Hiding the comment allows us to immediately suppress spam or offensive material
until the staff has had a chance to process it.

Comment 4

[Jon Stritar]

Hiding comments that are flagged would also introduce an entirely different type
of spam - people could go through marking every comment as flagged, and they
would all disappear.

Comment 5

[alanjstr]

1) people do already go through and flag many comments
2) when flagging a comment it requires a confirmation

Comment 6

[Jon Stritar]

Attachment: a patch to get rid of the error for now

This just gets rid of the error when a comment is already flagged.

Comment 7

[Cameron]

Comment flagging is now only avaliable to the add-on developer/s. 

Please reconfirm.

Comment 8

[Cameron]

err.. -> Developer Pages

Comment 9

[Mike Shaver (:shaver emeritus)]

The ship has sailed on changes to the v1 comment flaggery.