297948 - after deleting an account, group by Account sort in global inbox results in crash

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2005061606-trunk tbird build on Mac OS X 10.4.1. I crash when I
attempt to group sort via Account for a global inbox POP account.

1. make sure you've got at least two POP accounts set to use the global inbox.

2. get mail for the POP accounts.

3. from the column picker, display the Account column.

4. click to sort the message pane by Account.

5. hit G key to group sort.

results: tbird crashed. talkback is backed up, but here are some incident #s:

TB6736829E
TB6736811Y
TB6736800G
TB6736752M

Comment 1

[David :Bienvenu]

taking - this works for me, but I'll look at the talkback reports once it's indexed.

Comment 2

[sairuh (rarely reading bugmail)]

hrm, now I can no longer reproduce this using a fresh profile.

iirc, in the crashing profile I had (a) disassociated a POP account from the
global inbox, as well as (b) removed another POP account from it altogether (I
had started with 3 POP accounts). wonder if either of those put it into a
strange state to cause the crash...

hm, (a) doesn't seem to have been the culprit.

looking at (b) now...

Comment 3

[sairuh (rarely reading bugmail)]

ah, it occurs after I've removed a POP account!

revised recipe:

1. have a global inbox with at least 2 accounts.

2. get mail for all accounts.

3. go into the Account Manager and remove one of the POP accounts in the global
inbox.

4. sort by Account.

5. hit G.

results: crash.

Comment 4

[sairuh (rarely reading bugmail)]

in case the stacks differ wildly (hope not), the last crash incident for comment
3 is TB6737251W.

Comment 5

[timeless]

they're all the same, and i believe they're all garbage. sairuh, wanna try a
attaching a log from CrashReporter?

Incident ID: 6737251
Stack Signature	0xffff8834 1673886d
Product ID	ThunderbirdTrunk
Build ID	2005061605
Trigger Time	2005-06-16 14:44:31.0
Platform	MacOSX
Operating System	Darwin 8.1.0
Module	
URL visited	
User Comments	group sort via Account in global inbox: it occurs after _removing_
a POP account.
Since Last Crash	702 sec
Total Uptime	11532 sec
Trigger Reason	SIGBUS: Bus Error: (signal 10)
Source File, Line No.	N/A
Stack Trace 	
0xffff8834
nsStringKey::Clone() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/xpcom/ds/nsHashtable.cpp,
line 712]
thunderbird-bin + 0x3585a0 (0x003585a0)
thunderbird-bin + 0x358858 (0x00358858)
thunderbird-bin + 0x357cf4 (0x00357cf4)
_XPTC_InvokeByIndex()
thunderbird-bin + 0x89b81c (0x0089b81c)
thunderbird-bin + 0x88f790 (0x0088f790)
js_Invoke() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/js/src/jsinterp.c, line
1178]
js_Interpret() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/js/src/jsinterp.c, line
3472]
js_Invoke() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/js/src/jsinterp.c, line
1198]
js_InternalInvoke() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/js/src/jsinterp.c, line
1276]
JS_CallFunctionValue() 
[/builds/tinderbox/Tb-Trunk/Darwin_7.9.0_Depend/mozilla/js/src/jsapi.c, line 3960]
thunderbird-bin + 0x28d660 (0x0028d660)
thunderbird-bin + 0x791afc (0x00791afc)
thunderbird-bin + 0x790520 (0x00790520)
thunderbird-bin + 0x78f168 (0x0078f168)
thunderbird-bin + 0x2cf9b0 (0x002cf9b0)
thunderbird-bin + 0x2220f0 (0x002220f0)
thunderbird-bin + 0x2252a4 (0x002252a4)
thunderbird-bin + 0x1c2f90 (0x001c2f90)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x254c34 (0x00254c34)
thunderbird-bin + 0x1a9718 (0x001a9718)
thunderbird-bin + 0x1a92a4 (0x001a92a4)
thunderbird-bin + 0x25f0fc (0x0025f0fc)
thunderbird-bin + 0x25e4e8 (0x0025e4e8)
thunderbird-bin + 0x6765dc (0x006765dc)
thunderbird-bin + 0x887a10 (0x00887a10)
thunderbird-bin + 0x887a9c (0x00887a9c)
thunderbird-bin + 0x88338c (0x0088338c)
thunderbird-bin + 0x98ae24 (0x0098ae24)
AE.309.0.0 + 0x2a40 (0x91450a40)
AE.309.0.0 + 0xe04c (0x9145c04c)
AE.309.0.0 + 0x69d8 (0x914549d8)
AE.309.0.0 + 0x64b4 (0x914544b4)
HIToolbox.219.0.0 + 0xb7068 (0x931d1068)
HIToolbox.219.0.0 + 0x11c7ec (0x932367ec)
HIToolbox.219.0.0 + 0xe318 (0x93128318)
HIToolbox.219.0.0 + 0x7d04 (0x93121d04)
HIToolbox.219.0.0 + 0x720c (0x9312120c)
HIToolbox.219.0.0 + 0xdf90 (0x93127f90)
HIToolbox.219.0.0 + 0x11c5f8 (0x932365f8)
HIToolbox.219.0.0 + 0x11bd48 (0x93235d48)
HIToolbox.219.0.0 + 0x11b774 (0x93235774)
HIToolbox.219.0.0 + 0x11b358 (0x93235358)
HIToolbox.219.0.0 + 0xd1f58 (0x931ebf58)
HIToolbox.219.0.0 + 0xd1a20 (0x931eba20)
HIToolbox.219.0.0 + 0x4820 (0x9311e820)
HIToolbox.219.0.0 + 0x7ab4 (0x93121ab4)
HIToolbox.219.0.0 + 0x720c (0x9312120c)
HIToolbox.219.0.0 + 0x7088 (0x93121088)
HIToolbox.219.0.0 + 0xd16c8 (0x931eb6c8)
HIToolbox.219.0.0 + 0xe30c (0x9312830c)
HIToolbox.219.0.0 + 0x7d04 (0x93121d04)
HIToolbox.219.0.0 + 0x720c (0x9312120c)
HIToolbox.219.0.0 + 0xdf90 (0x93127f90)
HIToolbox.219.0.0 + 0x4ee70 (0x93168e70)
HIToolbox.219.0.0 + 0xede24 (0x93207e24)
HIToolbox.219.0.0 + 0xeda78 (0x93207a78)
HIToolbox.219.0.0 + 0xed8d0 (0x932078d0)
HIToolbox.219.0.0 + 0xed65c (0x9320765c)
HIToolbox.219.0.0 + 0xed5bc (0x932075bc)
thunderbird-bin + 0x87d4cc (0x0087d4cc)
thunderbird-bin + 0x87d3b0 (0x0087d3b0)
thunderbird-bin + 0x4f80c0 (0x004f80c0)
thunderbird-bin + 0xea78 (0x0000ea78)
thunderbird-bin + 0xa010 (0x0000a010)
thunderbird-bin + 0x9e90 (0x00009e90)

Comment 6

[David :Bienvenu]

Attachment: proposed fix

make sure we don't return a null account string.

Comment 7

[sairuh (rarely reading bugmail)]

Attachment: crash report logfile

Comment 8

[timeless]

Comment on attachment 186557 [details] [diff] [review]
proposed fix

>Index: nsMsgDBView.cpp
>@@ -537,6 +537,13 @@
>+    *aAccount = ToNewUnicode(accountKey);
>+    *aAccount = nsCRT::strdup(NS_LITERAL_STRING("").get());
this isn't a legal pairing, you're mixing allocators (nsCRT and nsMemory)

Comment 9

[Boris Zbarsky [:bzbarsky]]

And of course you can still return null if the strdup fails with OOM (which it can).