297990 - choose-product.html.tmpl generates improper indentation for product descriptions wrap to a second line.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Aaron Larson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

The choose-product.html.tmp file for 2.18 (and apparently the tip) specifies a
' ' as the first character of the description.  It should specify the
' ' as the last character of table element for the product description.

[root@aaron-home global]# diff -c choose-product.html.tmpl.~1~
choose-product.html.tmpl 
*** choose-product.html.tmpl.~1~	2004-01-18 12:39:28.000000000 -0600
--- choose-product.html.tmpl	2005-06-17 01:52:53.000000000 -0500
***************
*** 44,54 ****
      <th align="right" valign="top">
        <a href="[% target %]?product=[% p FILTER url_quote %]
              [% IF format %]&amp;format=[% format FILTER url_quote %][% END %]">
!       [% p FILTER html %]</a>:
      </th>
  
      [% IF proddesc.$p %]
!       <td valign="top">&nbsp;[% proddesc.$p %]</td>
      [% END %]
    </tr>
  [% END %]
--- 44,54 ----
      <th align="right" valign="top">
        <a href="[% target %]?product=[% p FILTER url_quote %]
              [% IF format %]&amp;format=[% format FILTER url_quote %][% END %]">
!       [% p FILTER html %]</a>:&nbsp;
      </th>
  
      [% IF proddesc.$p %]
!       <td valign="top">[% proddesc.$p %]</td>
      [% END %]
    </tr>
  [% END %]

Reproducible: Always

Steps to Reproduce:
Visit the URL.

Comment 1

[Aaron Larson]

This seems like a pretty harmless patch.  I'll do it if you'd like.

Comment 2

[Marc Schumann [:Wurblzap]]

Please ask for approval after there is a reviewed patch. Asking for approval is
the last step before checkin :)

Aaron, it'd be great if you attached a patch and asked for review (by setting r?
on your patch).

Comment 3

[Aaron Larson]

Attachment: Patch to fix whitespace in choose-product template.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Ultimately whitespace issues like this should be fixed with CSS properties, but
this is OK for now.

Comment 5

[Frédéric Buclin]

Checking in template/en/default/global/choose-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-product.html.tmpl,v
 <--  choose-product.html.tmpl
new revision: 1.13; previous revision: 1.12
done