298019 - improve search documentation in Using Firefox document

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Gids Goldberg]

I've had a go at cleaning up the Using Firefox document. One omission was that
the search engine drop down menu was never mentioned.

Comment 1

[Gids Goldberg]

Attachment: cleans up Using Firefox page

*Fixed Location Bar term
*Used correct Enter key string
*Adds Search Engine choice tip

Comment 2

[Steffen Wilberg]

Comment on attachment 186598 [details] [diff] [review]
cleans up Using Firefox page

> <p><strong>Don't know a URL</strong>? Try typing a general word (such as
>+  &quot;gifts&quot; or &quot;flowers&quot;) into the Search bar and hitting &enterKey;.
>+  This will take you to the top result in Google for that word.</p>
No, this will use the engine you have currently selected. The default engine is
Google, but the user might have changed it. And while we're at it, I don't like
searching for a "general word (surch as gifts or flowers)". Users should just
enter what they're looking for, especially in Google.

>+<p><strong>Tip:</strong> You can click on the <em>Search Engine Icon</em> to choose an alternative Search Engine.</p> 
Maybe we should mention that you need to do a left-click.
And you can add additional search engines by selecting "Add Engines...".

Comment 3

[Gids Goldberg]

>No, this will use the engine you have currently selected 
I can't reproduce this on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b2) Gecko/20050617 Firefox/1.0+ seems to be still set by keyword.URL for me.

>And you can add additional search engines by selecting "Add Engines..."
This is due to be renamed in Bug 233308 maybe we should hold out for the
resolution of that bug.

Comment 4

[Steffen Wilberg]

Er, scratch the first paragraph of comment 2. I thought that was about the
Search Bar as well, not the Location Bar.

I agree that bug 233308 should be fixed before. I'll make a new patch for that soon.

Comment 5

[Gids Goldberg]

Changing the summary to make this bug much more specific. 

Comment 6

[Steffen Wilberg]

Attachment: better patch

I guess we can't wait for bug 233308 to be fixed.

No wonder I was confused: That sentence is in the section of the Location Bar,
it describes an action which only works in the Location Bar, yet it said Search
Bar (second hunk in the patch).

Comment 7

[Jeff Walden (gone starting June 8)]

Comment on attachment 188104 [details] [diff] [review]
better patch

>-<p><strong>Don't know a URL</strong>? Try typing a general word (such as
>-  &quot;gifts&quot; or &quot;flowers&quot;) into the Search bar and hit enter.
>-  This will start a web search for the topic you typed in and will tell you
>-  the URL you are looking for.</p>
>+<p><strong>Don't know a URL</strong>? Try typing e.g. a product or company name
>+  into the Location Bar and hit &enterKey;. This will take you to the top result
>+  in Google for that term.</p>

This sounds stilted to me.  The part "e.g. a product or company name" just
sounds really odd, and it completely ignores non-commercial searches.  How
about the following instead of the second sentence:

"Try typing some words that describe the page you want to find into the
Location Bar and hit &enterKey;."

I think this is better but not excellent.  If you have a suggestion that sounds
better than this, by all means make it.

>+<p><strong>Tip:</strong> You can click on the Search Engine icon to choose
>+  another Search Engine. There are Search Engines which search the whole web
>+  like Google; others only search specific sites like Amazon.com.
>+  Select <em>Add Engines...</em> to install additional Search Engines.</p>

We should mention the relevant keyboard shortcuts here, because otherwise the
shortcut's incredibly difficult to find.  Adding, "You can also switch between
installed Search Engines by pressing &accelKey;+<kbd>Up Arrow</kbd> and
&accelKey;+<kbd>Down Arrow</kbd>." after the first sentence would do the job
just fine.

Anyway, r- until we wrap up these issues.

Comment 8

[Steffen Wilberg]

Attachment: patch v2.1

How's this?

Comment 9

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml,v  <-- 
using_firebird.xhtml
new revision: 1.26; previous revision: 1.25
done