Rename calIRecurrenceRule endDate to untilDate

RESOLVED FIXED in 1.0b1

Status

Calendar
Internal Components
--
trivial
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: gekacheka, Assigned: Fallen)

Tracking

unspecified
1.0b1

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+
Build Identifier: trunk

"endDate" is a poor name for the recur-until date.
It is easy to confuse with the end date of the event.  
It is also different from event endDate in that it is inclusive 
rather than exclusive.  

RFC2445 uses "UNTIL" rather than enddate.  
Suggest renaming to use the same terminology:

calIRecurrenceRule.idl

-   attribute calIDateTime endDate;
+   attribute calIDateTime untilDate;


Reproducible: Always

Steps to Reproduce:
Assignee: shaver → vladimir
Assignee: vladimir → nobody
(Assignee)

Comment 1

8 years ago
Created attachment 397941 [details] [diff] [review]
Fix - v1

Makes sense, this patch should fix it.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #397941 - Flags: review?(ssitter)
(Assignee)

Updated

8 years ago
Whiteboard: [needs review]
(Assignee)

Updated

8 years ago
Attachment #397941 - Flags: review?(ssitter) → review?(Mozilla)
Comment on attachment 397941 [details] [diff] [review]
Fix - v1

Looks good to me.
r=markus
Attachment #397941 - Flags: review?(Mozilla) → review+
(Assignee)

Comment 3

8 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7045fb8f5e2d>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Whiteboard: [needs review]
(Assignee)

Updated

7 years ago
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.