Closed
Bug 298097
Opened 19 years ago
Closed 15 years ago
Rename calIRecurrenceRule endDate to untilDate
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: gekacheka, Assigned: Fallen)
Details
Attachments
(1 file)
7.34 KB,
patch
|
Taraman
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+ Build Identifier: trunk "endDate" is a poor name for the recur-until date. It is easy to confuse with the end date of the event. It is also different from event endDate in that it is inclusive rather than exclusive. RFC2445 uses "UNTIL" rather than enddate. Suggest renaming to use the same terminology: calIRecurrenceRule.idl - attribute calIDateTime endDate; + attribute calIDateTime untilDate; Reproducible: Always Steps to Reproduce:
Assignee: shaver → vladimir
Assignee: vladimir → nobody
Assignee | ||
Comment 1•15 years ago
|
||
Makes sense, this patch should fix it.
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs review]
Assignee | ||
Updated•15 years ago
|
Attachment #397941 -
Flags: review?(ssitter) → review?(Mozilla)
Comment 2•15 years ago
|
||
Comment on attachment 397941 [details] [diff] [review] Fix - v1 Looks good to me. r=markus
Attachment #397941 -
Flags: review?(Mozilla) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7045fb8f5e2d> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Updated•15 years ago
|
Whiteboard: [needs review]
Assignee | ||
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•