298190 - The "200 bugs" limit in buglist.cgi should be a constant, not a magic number.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

Apparently, right now the limit of 200 bugs for a query in buglist.cgi is
actually hard-coded as the number "200."

It should instead be a constant.

Comment 1

[Tiago Mello [:timello]]

Attachment: v1: using a constant instead of hard code value.

Comment 2

[Christian Reis]

Comment on attachment 186797 [details] [diff] [review]
v1: using a constant instead of hard code value.

This constant is also used in the template and in the error message. I am not
quite sure how to communicate constants to templates -- is Bugzilla::Constants
available there?

Comment 3

[Tiago Mello [:timello]]

Attachment: v2: move the bug list limit constant to Constant.pm

Comment 4

[Christian Reis]

Comment on attachment 186807 [details] [diff] [review]
v2: move the bug list limit constant to Constant.pm

There is code in the template (landed by LpSolit yesterday) that also needs to
be changed (I said "template /and/ error message"). 

Note also that it's not BUG_LIST_LIMIT but FULLTEXT_BUGLIST_LIMIT.

Comment 5

[Tiago Mello [:timello]]

Attachment: v3: changes after checkin of the bug 244533.

Comment 6

[Christian Reis]

Comment on attachment 186853 [details] [diff] [review]
v3: changes after checkin of the bug 244533.

Tiago, you need to document constants added. r=kiko with that.

Comment 7

[timeless]

the number 200 happens to be wrong since 200 items containing 6 character bugs
and commas blows cookie limits for browsers.

Comment 8

[Christian Reis]

Well, timeless, what's a number that might work? 100? 50? At any rate, I don't
think this is reason to hold this patch up -- it's currently broken in that
respect anyway. Timello, move ahead.

Comment 9

[Tiago Mello [:timello]]

Attachment: v4: comment for the constant.

Moving ahead...
Keeping 200, we can decide what we should do with that number in other bug,
though.

Comment 10

[Christian Reis]

Comment on attachment 186915 [details] [diff] [review]
v4: comment for the constant.

I was thinking more of POD documentation, but this is okay for now.

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 186915 [details] [diff] [review]
v4: comment for the constant.

>Index: buglist.cgi
>@@ -662,7 +662,7 @@ if (!$order || $order =~ /^reuse/i) {
>        
>         # Cookies from early versions of Specific Search included this text,
>         # which is now invalid.
>-        $order =~ s/ LIMIT 200//;
>+        $order =~ s/ LIMIT \d+//;

It isn't necessary to change this.  See the comment immediately above it. :)

Comment 12

[Tiago Mello [:timello]]

Attachment: v5: simple change.

Comment 13

[Frédéric Buclin]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.297; previous revision: 1.296
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.24; previous revision: 1.23
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v
 <--  messages.html.tmpl
new revision: 1.29; previous revision: 1.28
done