Need SHORT_LIBNAME for browserdirprovider.dll

RESOLVED FIXED

Status

()

Firefox
Build Config
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Rich Walsh, Assigned: mkaply)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
This new module needs a short dll name.  The attached patch to
mozilla/browser/components/dirprovider/Makefile.in dubs it "brwsrdir".
(Reporter)

Comment 1

13 years ago
Created attachment 186774 [details] [diff] [review]
makefile patch for BrowserDirectoryProvider

Comment 2

13 years ago
I learned in Bug 286494 that Windows uses the same variable so one needs to do
something like this

ifneq ($(OS_ARCH),WINNT)
SHORT_LIBNAME        = brwsrdir
endif
(Assignee)

Comment 3

13 years ago
yeah, definitely need the WINNT stuff.
(Reporter)

Comment 4

13 years ago
Created attachment 186893 [details] [diff] [review]
revised patch
Attachment #186774 - Attachment is obsolete: true

Comment 5

13 years ago
Why does this need a shortname? Aren't the OS/2 release builds static builds?

Comment 6

13 years ago
I think Mike's release builds were non-static, but even if they were static we
should still keep non-static builds working on OS/2.

Comment 7

13 years ago
The are several things I don't understand here: a while back I thought mkaply
told me not to worry about long names any more: we use longnames (such as
extensions-startup.manifest) in the profile.

Furthermore, I don't think you (or I) should be worrying about non-static
configurations: I have been adding little dynamic components willy-nilly
trusting that in release configurations they will be merged into the static
binary, and your perf is going to suck if you are releasing dynamic builds.

Comment 8

13 years ago
Long filenames are not a problem on OS/2, _except_ for DLLs. If DLLs have more
than 8.3 chars they cannot be loaded and Firefox probably won't run, if the DLL
is dynamically linked at compile time.
I agree that static builds are the way to go for releases, even though they
don't seem to make much of a difference regarding performance. (I don't have
numbers to back this up at the moment, though.) But for debugging etc. we need
to keep the SHORT_LIBNAME stuff just to keep Firefox running.
(Assignee)

Comment 9

13 years ago
Also, debug builds cannot be static on OS/2, so in order to debug, we have to
maintain the short names.

Updated

13 years ago
Attachment #186893 - Flags: superreview?(benjamin)
Attachment #186893 - Flags: review?(mozilla)

Updated

13 years ago
Attachment #186893 - Flags: superreview?(benjamin)
Attachment #186893 - Flags: review?(mozilla)
Attachment #186893 - Flags: review+
Attachment #186893 - Flags: approval-aviary1.1a2+
(Assignee)

Comment 10

13 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.