298210 - document the restoration of the Cmd+Arrow navigation shortcuts on Mac

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

Bug 254225 removed the Cmd+Arrow navigation shortcuts on Mac for back/forward.
Bug 291367 documented that change.

Bug 291516 restored those shortcuts.
This bug is about documenting that.

Comment 1

[Asaf Romano (gone)]

Note that the exposed keyboard shortcuts are still Cmd+[/Cmd+].

Comment 2

[Steffen Wilberg]

Attachment: patch

Tested on Linux. Mano, can you please try that on Mac?

Comment 3

[Jeff Walden (gone starting June 8)]

Comment on attachment 186802 [details] [diff] [review]
patch

>-        <span class="noMac">&altKey;+<kbd>Left Arrow</kbd></span>
>-        <span class="noWin"><br/>&accelKey;+<kbd>[</kbd></span></td>
>+        <span class="noMac">&altKey;+<kbd>Left Arrow</kbd><br/></span>
>+        <span class="noWin">&accelKey;+<kbd>[</kbd></span>
>+        <span class="mac"><br/>&accelKey;+<kbd>Left Arrow</kbd></span></td>

I don't have a working Windows build environment because I wiped my hard drive
to install FC4 and MS's newest SDK breaks free VC++ builds without tree hacks I
haven't had time to make.  That said, it looks like there's a hanging <br/> on
Windows.

>-        <span class="noMac">&altKey;+<kbd>Right Arrow</kbd></span>
>-        <span class="noWin"><br/>&accelKey;+<kbd>]</kbd></span></td>
>+        <span class="noMac">&altKey;+<kbd>Right Arrow</kbd><br/></span>
>+        <span class="noWin">&accelKey;+<kbd>]</kbd></span>
>+        <span class="mac">&accelKey;+<kbd>Right Arrow</kbd></span></td>

Ditto the previous comment here.  Also, I think on Mac you'll get Cmd+] jammed
together with Cmd+Right Arrow with no <br/> between the two.

I'm falling asleep here, tho, so tell me if I'm not reading this correctly. 
Also, keep in mind the order in which these are displayed is mostly irrelevant,
so if it works better to change the display order, by all means do so.

Comment 4

[Steffen Wilberg]

Attachment: split up this mess

This is ridiculous. Every time we have a change here, we have to completely
rearrange this, run through it several times, and test it on all platforms just
to make sure there's no mistake. Let's split up this mess.

Comment 5

[Jeff Walden (gone starting June 8)]

Comment on attachment 187066 [details] [diff] [review]
split up this mess

Change the formatting in both places like so to make it more readable:

>+        <span class="win">
>+          &altKey;+<kbd>Left Arrow</kbd><br/>
>+          <kbd>Backspace</kbd>
>+        </span>
>+        <span class="unix">
>+          &altKey;+<kbd>Left Arrow</kbd><br/>
>+          <kbd>Backspace</kbd><br/>
>+          &accelKey;+<kbd>[</kbd>
>+        </span>
>+        <span class="mac">
>+          &accelKey;+<kbd>[</kbd><br/>
>+          &accelKey;+<kbd>Left Arrow</kbd>
>+        </span>

...and r=me.

Comment 6

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.31; previous revision: 1.30
done