298212 - Tidy Token.pm / Email Template timestamp handling

Status: RESOLVED WONTFIX

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

followon from bug 297646

Currently the code in Token expects the timestamp to be in unix time..

glob     i'd still like to avoid str2time; it's pretty heavy
LpSolit  why don't you let the caller use str2time if needed
LpSolit  most of the time, we take it to pass it to templates, which use the
         "string" version
glob     it's only used by IssueEmailChangeToken and IssuePasswordToken.
         both expect unix time
glob     old code was my $token_ts = time();
LpSolit  :(
LpSolit  which part of the code calls these routines?
glob     both from user preferences
glob     changing email address and changing password
LpSolit  and do we need unix time here??? sounds wrong
glob     i think it's so the template has control over the time format
glob     different localizations would want different formats
LpSolit  templates should use Util::format_time which is available using 
         FILTER time
LpSolit  sounds like a big hack
glob     [% expiration_ts = token_ts + (max_token_age * 86400) %]
glob     eww
LpSolit  this should be done in userprefs.cgi
LpSolit  and we should let this file use str2time() if it wants to deal with it
glob     yeah. i agree, it's a bit messy.
glob     how about we run with str2time in token, and open another bug to 
         tidy things up?
LpSolit  glob: do what you think is the best to do (no hack please)

Comment 1

[Frédéric Buclin]

Byron, I forgot the whole discussion, but is that still something we want? This bug looks like WONTFIX or WFM to me. I think the code we have now in Token.pm is fine.

Comment 2

[:glob ✱]

agree; --> wontfix