298220 - Graphs should use localised terms for statuses and resolutions

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Emmanuel Seyman]

I've been trying to get the graphs generated by Bugzilla to display localised
statuses and resolutions. I did this for pie graphs (the easiest to do) but I
found out that GD::Graph mangles UTF-8 strings. Converting
global/field-descs.none.tmpl to ISO-8859-1 solves this but, obviously, this is a
hack.

Complicating the issue even more is the fact that templates aren't always in
UTF-8. For exemple, Marc (cc-ing) releases German templates in both encodings so
we'ld need to test encoding on the fly and convert if needed. I'm not sure this
is possible and even if it is, I doubt it's possible without going with perl 5.8.

Comment 1

[Emmanuel Seyman]

Attachment: Use localised statuses and resolutions

Here's a patch that modifies the bar, line and pie generating templates to use
localised statuses and resolutions. I can't figure out how to make GD accept
UTF-8 strings but this is only a problem if you use non-ASCII characters. Since
the English terms all use ASCII, I can't consider this a regression. This just
needs to be documented somewhere and I'll be happy to supply the appropriate
patch to Bugzilla's documentation.

Patch applies to today's CVS HEAD. Asking for review from Myk.

Comment 2

[Emmanuel Seyman]

Comment on attachment 188883 [details] [diff] [review]
Use localised statuses and resolutions

Also asking for review from wurblzap since he's reviewed similar patches in the
past.

Comment 3

[Emmanuel Seyman]

Comment on attachment 188883 [details] [diff] [review]
Use localised statuses and resolutions

Oops. r? for Gerv

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 188883 [details] [diff] [review]
Use localised statuses and resolutions

Uuuuugly. I guess this will go away with customised resolutions and statuses...
In the mean time, I suppose we don't have any choice - unless there's a neater
way of doing this operation in TT, for example using maps.

Still, r=gerv.

Gerv

Comment 5

[Marc Schumann [:Wurblzap]]

Comment on attachment 188883 [details] [diff] [review]
Use localised statuses and resolutions

Ugly, yes... but it works well; r=wurblzap. And wrt comment 0 and comment 1 --
it's not this patch's fault that GD is not UTF-8-friendly :)

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 188883 [details] [diff] [review]
Use localised statuses and resolutions

This seems to have been reviewed twice already.  Is there something specific I
am being asked to look at in the patch?

Comment 7

[Emmanuel Seyman]

Sorry, requesting approval and approval2.20

Comment 8

[Frédéric Buclin]

tip:

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/reports/report-bar.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-bar.png.tmpl,v
 <--  report-bar.png.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/reports/report-line.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-line.png.tmpl,v
 <--  report-line.png.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/reports/report-pie.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-pie.png.tmpl,v
 <--  report-pie.png.tmpl
new revision: 1.4; previous revision: 1.3
done


2.20rc1:

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v
 <--  field-descs.none.tmpl
new revision: 1.10.2.1; previous revision: 1.10
done
Checking in template/en/default/reports/report-bar.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-bar.png.tmpl,v
 <--  report-bar.png.tmpl
new revision: 1.4.10.1; previous revision: 1.4
done
Checking in template/en/default/reports/report-line.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-line.png.tmpl,v
 <--  report-line.png.tmpl
new revision: 1.5.10.1; previous revision: 1.5
done
Checking in template/en/default/reports/report-pie.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-pie.png.tmpl,v
 <--  report-pie.png.tmpl
new revision: 1.3.12.1; previous revision: 1.3
done