Closed Bug 298268 Opened 15 years ago Closed 8 years ago

editparams.cgi should accept urlbase, sslbase, etc.. with or without a trailing slash

Categories

(Bugzilla :: Administration, task, trivial)

task
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: zach, Assigned: LpSolit)

Details

Attachments

(1 file)

Currently, doeditparams dies with a very small warning if baseurl does not end
with a slash. We should simply try adding a slash if there isn't one, since we
can safely assume that is what the user had in mind.
Attached patch patch, v1Splinter Review
The webdotbase parameter doesn't take a slash at the end of the URL. All other *base parameters do. This hack is much easier to do than to fix all checkers to return a sanitized value, especially when you know that only 4 parameters would benefit from it. Once bug 303662 is implemented (param objects), this hack can go into their respective checkers.
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #553510 - Flags: review?(glob)
Summary: editparams should accept baseurl with or without a trailing slash → editparams.cgi should accept urlbase, sslbase, etc.. with or without a trailing slash
Target Milestone: --- → Bugzilla 4.2
Comment on attachment 553510 [details] [diff] [review]
patch, v1

Review of attachment 553510 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and works as expected. r=dkl
Attachment #553510 - Flags: review+
Attachment #553510 - Flags: review?(glob)
Flags: approval4.2+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified editparams.cgi
Committed revision 7934.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified editparams.cgi
Committed revision 7909.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.