298273 - Marking duplicates misses 'Bug' before the number

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Hermann Schwab]

If I dupe a bug, there are two messages inserted:

*** Bug 298141 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 297725 ***

2nd message should be:
*** This bug has been marked as a duplicate of Bug 297725 ***

Reason: the message gives a bad example to people reading and writing comments.
If you write in a comment simply '297725', that number doesn´t get linkified.
If you write in a comment 'bug 297725' that entry gets linkified, you see the
summary of the bug if you hover over the link so you don´t have to follow the
link to see the summary.



end of bug, rant following:
I hate comments using numbers only, as I have to do some action to follow the
bug. Normally I use some other bug already open and replace it's number with the
new bugnumber, or I don´t follow, if the bug is of little interest.

Tinderbox linkifies each and every number, so developers are used to omitting
'Bug', and the result can be seen in Bugzilla.
Other people are writing about 'bugs 123456 and 234567' and that numbers also
don´t get linkified.
I`m missing a short help at a prominent place 'Howto refer to bugnumbers and
comments'
Tell people that 'comment n' refers to the n'th comment in this bug, that
comment 0 is the original comment opening the bug, and refering to a comment in
another bug must be written as 'bug 123 comment 2'
I also would like if attachments get numbered like comments, belonging to a bug,
so if an attachment is used as testcase in another bug, you know were it came from.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Frédéric Buclin]

Comment on attachment 187128 [details] [diff] [review]
Patch

>-    # Duplicate markers
>+    # Old duplicate markers
>     $text =~ s~(?<=^\*\*\*\ This\ bug\ has\ been\ marked\ as\ a\ duplicate\ of\ )

That's the problem. In order to be backward compatible, we cannot remove this
line, even with the new 'bug XXX' format. Why the guy who wrote the duplicate
message did not think about adding the word "bug" instead of hacking quoteUrls?
:(


>         $comment .= "\n\n*** This bug has been marked " .
>-                    "as a duplicate of $duplicate ***";
>+                    "as a duplicate of bug $duplicate ***";

'bug' should be customizable, using something similar to [% terms.bug %]. This
will be fixed by bug 223880.

So this patch is fine. r=LpSolit

Comment 3

[Dave Miller [:justdave]]

I'm not going to take this for 2.20...  messing with that text is a huge kettle
of worms because of all the stuff that depends on it being worded the way it is,
so if we're going to mess with it, I'd prefer it to be outside of a freeze and
after lots of discussion.

Comment 4

[Frédéric Buclin]

*** Bug 190042 has been marked as a duplicate of this bug. ***

Comment 5

[Dave Miller [:justdave]]

Let's re-request approval after we've had a bit more discussion here.  Altering
this text potentially has a lot of backward-compatibility issues because this
text (or regexps that match it) is hard coded in multiple places in
checksetup.pl.  We need to make sure all the implications of making this change
have been thought through first.

Comment 6

[Marc Schumann [:Wurblzap]]

checksetup.pl looks for the old dup text to populate the duplicates table of
pre-2.12 (?) installations -- bug 25693. This will continue to work because the
old dup comments have the old dup text and will therefore be found when upgrading.

That's all I found.

Comment 7

[Frédéric Buclin]

Marc is right, checksetup.pl at lines 2424 and 2439 checks if the duplicates
table is empty and if it's the case, it looks for this string in the longdescs
table to fill the duplicates table. So this part of the code is only used when
upgrading. But upgrading means that the old string format is in use, not the new
one. And an upgraded installation doesn't care about this part of the code
anymore because the duplicates table is already populated.

And quoteUrls() in globals.pl will linkify the bug number in all cases, as both
syntaxes are caught.

Requesting approval again!

Comment 8

[Max Kanat-Alexander]

Mozbot's Bugzilla.bm will have to be modified to accept both the old and new syntax.

Comment 9

[Dave Miller [:justdave]]

ok, fair enough.

Comment 10

[Frédéric Buclin]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.331; previous revision: 1.330
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.268; previous revision: 1.267
done