298291 - Anchor information does not append to URL after navigating to an anchor

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[signups]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.2; Mac_PowerPC)
Build Identifier: 2005062008 (0.9a1)

After clicking on an anchor link within a page, the url does not change to
correctly represent the correct url path.  This makes it impossible to copy the
url with the correct anchor information so that it can be pasted or sent to others.

Reproducible: Always

Steps to Reproduce:
1.Go to the webpage indicated above.
2. Click on "Directions" it is an anchor within the page
3.

Actual Results:  
Described above

Expected Results:  
Described above

Comment 1

[Wevah (Nate Weaver)]

Well, this is sure odd. Temporary workaround: After clicking the link and moving
to the anchor, click in the location field and press escape; the correct URL
will show up.

->NEW

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this a dupe of bug 149817?  smfr notes that bug affects session history  and
bookmarks; is the location bar part of session history?

An additional work-around is to switch tabs and return to the original one.

Comment 3

[Wevah (Nate Weaver)]

(In reply to comment #2)
> Is this a dupe of bug 149817?  smfr notes that bug affects session history  and
> bookmarks; is the location bar part of session history?
> 
> An additional work-around is to switch tabs and return to the original one.

I don't think it's the same; I can't reproduce that one.

Comment 4

[Mike Pinkerton (not reading bugmail)]

is this a regression?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> is this a regression?

Yep.  Worked in 0.8.4 (after a slight delay to post the anchor part)

Comment 6

[Simon Fraser [no longer active]]

This happened because of an over-zealous null check on the nsIRequest.

Patch:

Index: CHBrowserListener.mm
===================================================================
RCS file: /cvsroot/mozilla/camino/src/embedding/CHBrowserListener.mm,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- CHBrowserListener.mm	26 May 2005 04:32:26 -0000	1.17
+++ CHBrowserListener.mm	28 Jun 2005 03:43:09 -0000	1.18
@@ -600,7 +600,7 @@
 CHBrowserListener::OnLocationChange(nsIWebProgress *aWebProgress, nsIRequest
*aRequest, 
                                           nsIURI *aLocation)
 {
-  if (!aLocation || !aWebProgress || !aRequest)
+  if (!aLocation || !aWebProgress)
     return NS_ERROR_FAILURE;
 
   // only pay attention to location change for our nsIDOMWindow
@@ -610,9 +610,13 @@
   if (windowForProgress != ourWindow)
     return NS_OK;
 
-  nsresult requestStatus = NS_OK;
-  aRequest->GetStatus(&requestStatus);
-  BOOL requestOK = NS_SUCCEEDED(requestStatus);
+  BOOL requestOK = YES;
+  if (aRequest)  // aRequest can be null (e.g. for relative anchors)
+  {
+    nsresult requestStatus = NS_OK;
+    aRequest->GetStatus(&requestStatus);
+    requestOK = NS_SUCCEEDED(requestStatus);
+  }
   
   nsCAutoString spec;
   aLocation->GetSpec(spec);

Checked in.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 300341 has been marked as a duplicate of this bug. ***