298306 - For new products, the charting error message "The tool which gathers bug counts has not been run yet" is misleading

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[manoj]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: Bugzilla 2.18

I have created a schedule task "Collectstats.pl". After that "old chart" was 
not displaying internal error. But as I create a new product and then run this 
scheduled task. After that open the "Old Chart" and select old products name 
in "Product" and click "Continue" it is not displaying any error. but if I 
select new product's name in "Product" option and click "Continue", it is 
displaying error message "The tool which gathers bug counts has not been run 
yet".

Reproducible: Always

Steps to Reproduce:
1.Create new product.
2.Run the scheduled task "collectstats.pl"
3.Open the "Old Chart" and select new product name in "Product" and 
click "Continue".
Actual Results:  
URL: http://bugzilla:81/reports.cgi?product=Shinsat&datasets=NEW%
3A&datasets=ASSIGNED%3A&datasets=REOPENED%3A&datasets=UNCONFIRMED%3A

Displaying Internal error ""The tool which gathers bug counts has not been run 
yet".

Expected Results:  
Shouldn't displayed any error. And should displayed graph with latest data.

Comment 1

[Marc Schumann [:Wurblzap]]

The error message is imho misleading for new products.

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Friendlier error message

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 187015 [details] [diff] [review]
Friendlier error message

>+        if ($product eq '-All-') {
>+            $product = '';
>+        }
>+        ThrowCodeError("chart_data_not_generated", {'product' => $product});

Nit: coding standards put a newline after a closing brace.

>-    The tool which gathers [% terms.bug %] counts has not been run yet.
>+    The tool which gathers [% terms.bug %] counts has not been run yet
>+    [% IF product %],
>+      at least not for two days since the <em>[% product %]</em> product
>+      has been created
>+    [% END %].

Did you check that the full stop ends up right up against "yet" in the case
when the extra text is not inserted?

The extra text does not have correct grammar. Try doing it as an entirely
separate case, and say:

The tool which gathers [% terms.bug %] counts each day needs to be run at least
twice after the creation of <em>[% product %]</em> before you can see graphs
for it. Please wait two days and try again.

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.1

(In reply to comment #3)
> Nit: coding standards put a newline after a closing brace.

Nit fixed.

> Did you check that the full stop ends up right up against "yet" in the case
> when the extra text is not inserted?

Yes I did.

> The extra text does not have correct grammar. Try doing it as an entirely

I did that and added some more elaborate text.

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 187677 [details] [diff] [review]
Patch 1.1

1) Fails runtests:

not ok 64 - (en/default) template/en/default/global/code-error.html.tmpl has
unfiltered directives:
#   74: product
# --ERROR
#     Failed test (t/008filter.t at line 131)

2) Where did the two days came from? Looks like the error goes away when the
collectstats.pl is run atleast once, not twice, after the product is created.

3) I'm concerned that this change doesn't make the error any less confusing..
What happens now is the "tool not run" error is shown only when a) it hasn't
been run and b) user chooses -All- product. If he/she chooses any other, the
product is claimed to be new one and user is instructed to just wait two days.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.2

(In reply to comment #5)
> 1) Fails runtests:

Fixed.

> 2) Where did the two days came from? Looks like the error goes away when the
> collectstats.pl is run atleast once, not twice, after the product is created.


Yup, once is sufficient.

> 3) I'm concerned that this change doesn't make the error any less confusing..


Enhanced.

Comment 7

[Teemu Mannermaa (:wicked)]

Comment on attachment 192176 [details] [diff] [review]
Patch 1.2

Hmm.. Sorry, technically this works but I don't think I still like the wording
used.. Neither did timely and he suggested following:

<timely> Charting data for the [% terms.product %] product is currently
unavailable because nothing has collected data for it since it was created.
<timely> Data must be collected for the product before graphs are available for
it.
<timely> --
<timely> No charting data has been collected.
<timely> --
<timely> Please wait a day and try again.
<timely> If you're still seeing this message <!-- can't we know that you tried
a day ago? -->
<timely> then you should contact the <a href="mailto:[% Param('maintainer')
%]">[% Param('maintainer') %]</a>
<timely> and reference this error.

(Note that [% terms.product %] needs to become <em>[% product FILTER html
%]</em> in that suggestion.)

So, I still have to r- this patch. Please, for the next patch, could you ask a
native english speaker for a review.

Comment 8

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.3

Ok, this one is probably it then.

If we really want to check whether we've seen the message a day ago, then I
think we should do it in another bug.

Comment 9

[Gervase Markham [:gerv]]

Comment on attachment 193547 [details] [diff] [review]
Patch 1.3

r=gerv.

Gerv

Comment 10

[Frédéric Buclin]

Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.78; previous revision: 1.77
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v
 <--  code-error.html.tmpl
new revision: 1.57; previous revision: 1.56
done