298357 - views need to colourize events by calendar color-pref

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect, P3)

Description

[Mike Shaver (:shaver emeritus)]

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

You might ask yourself "why is that being set twice? why does it not appear on
the item box in either case?".	I sure did.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 186938 [details] [diff] [review]
Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

r=vladimir; we need something similar for the calendar-month-view as well.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 186938 [details] [diff] [review]
Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

Checked this in, I'll work on the multiday view when I get the todo display
limping along for pav.

Comment 4

[Joey Minta]

Attachment: multiday view

This fixes things for me.  I find it odd that it was so simple.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 198707 [details] [diff] [review]
multiday view

r=dmose

Comment 6

[Joey Minta]

patch checked in

Comment 7

[Joey Minta]

We decided in IRC that coloring the background looks a lot better than coloring
the font.

Comment 8

[Joey Minta]

Attachment: use backgroundColor

This patch switches to using backgroundColor for calendar color preferences. 
We have to move the default background color into js to avoid conflicting rule
problems.  Also, this moves getContrastingColor into calendarUtils.js so that
both  Sunbird and Lightning can use it easily.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 198745 [details] [diff] [review]
use backgroundColor

r=dmose

Comment 10

[Joey Minta]

patch checked in.