views need to colourize events by calendar color-pref

RESOLVED FIXED in Lightning 0.1

Status

P3
normal
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: shaver, Assigned: jminta)

Tracking

unspecified
Lightning 0.1

Details

Attachments

(3 attachments)

Created attachment 186938 [details] [diff] [review]
Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

You might ask yourself "why is that being set twice? why does it not appear on
the item box in either case?".	I sure did.
Attachment #186938 - Flags: first-review?(vladimir)
Comment on attachment 186938 [details] [diff] [review]
Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

r=vladimir; we need something similar for the calendar-month-view as well.
Attachment #186938 - Flags: first-review?(vladimir) → first-review+
Comment on attachment 186938 [details] [diff] [review]
Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

Checked this in, I'll work on the multiday view when I get the todo display
limping along for pav.
Attachment #186938 - Attachment description: Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs → Add item-calendar attribute for the calendar's URI, maintain dynamic style rules to match user's prefs [checked in]

Updated

14 years ago
Priority: -- → P3

Updated

14 years ago
Target Milestone: --- → Lightning 0.8
(Assignee)

Comment 4

13 years ago
Created attachment 198707 [details] [diff] [review]
multiday view

This fixes things for me.  I find it odd that it was so simple.
Attachment #198707 - Flags: first-review?(dmose)
Comment on attachment 198707 [details] [diff] [review]
multiday view

r=dmose
Attachment #198707 - Flags: first-review?(dmose) → first-review+
(Assignee)

Comment 6

13 years ago
patch checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

13 years ago
We decided in IRC that coloring the background looks a lot better than coloring
the font.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

13 years ago
Created attachment 198745 [details] [diff] [review]
use backgroundColor

This patch switches to using backgroundColor for calendar color preferences. 
We have to move the default background color into js to avoid conflicting rule
problems.  Also, this moves getContrastingColor into calendarUtils.js so that
both  Sunbird and Lightning can use it easily.
(Assignee)

Updated

13 years ago
Assignee: shaver → jminta
Status: REOPENED → ASSIGNED
Attachment #198745 - Flags: first-review?(dmose)
Comment on attachment 198745 [details] [diff] [review]
use backgroundColor

r=dmose
Attachment #198745 - Flags: first-review?(dmose) → first-review+
(Assignee)

Comment 10

13 years ago
patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago13 years ago
Resolution: --- → FIXED

Updated

13 years ago
QA Contact: shaver → lightning
You need to log in before you can comment on or make changes to this bug.