298360 - calendar list needs better visible/not display

Status: RESOLVED DUPLICATE of bug 368558

(Calendar :: Lightning Only, defect)

Description

[Mike Shaver (:shaver emeritus)]

Should try checkbox image, and custom white-plus-transparent overlays for
calendar-color background.

(WTB: <treecol type="checkbox">)

Comment 1

[Joey Minta]

Attachment: add checkbox images

Replaces the current red background with checkbox images.  Basically a straight
port of what Sunbird does for its tasklist.  Doesn't do anything with calendar
colors yet, that'll take something a bit fancier.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 197481 [details] [diff] [review]
add checkbox images

r=dmose

Comment 3

[Joey Minta]

Comment on attachment 197481 [details] [diff] [review]
add checkbox images

patch checked in. leaving bug open to figure out the calendar colors issue.

Comment 4

[Joey Minta]

Attachment: add color column

This patch makes the Lightning calendar box look much like Sunbird's by adding an additional column for the calendar color.  Alternatively, it's possible to just color the background of the calendar's name cell.  I'm not sure if that's a better option from a user-experience standpoint.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

I talked to beltzner a bit about it in IRC, and here are his thoughts:

<emose> beltzner: got any opinion on bug 298360?
<beltzner> assuming that you can't actually colour the checkboxes, iCal style, it seems like a decent compromise
<beltzner> colouring the cell containing the calendar name seems both heavy and like it could lead to contrast problems with reading the name of the calendar
<emose> well, we have code to "get contrasting colors"
<emose> which is what we use to write the text on the event boxes
<emose> which are in the color
<emose> but you'd suggest coloring the checkboxes as the best option?
<beltzner> if at all possible, yeah
<emose> beltzner: ok, thanks
<beltzner> if you end up using the multiple columns, I'd suggest making the colour box appear at the RHS, slightly shorter than full cell height and valign=center'd
<beltzner> just as visual niceties ;)

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 204051 [details] [diff] [review]
add color column

Removing r?, since it sounds like a new patch is forthcoming.

Comment 7

[Stefan Sitter [:ssitter]]

Attachment: visual comparison Lightning <-> Sunbird

My two cents:
Sunbird currently displays the fields in this order:
[checkbox][color][calendarname]. 
In my opinion it should be the same order in Sunbird and Lightning. So either use the patch as is or use beltzners suggestions for both.

Nit: I think the proposed color column is too wide (25px), consuming too much space. My proposal would be to make it square sized or use the same width as the checkbox (18px).

Comment 8

[Joey Minta]

Attachment: several options

Here are several different visual presentation options.  Option 5 represents my attempt to make the checkboxes more transparent.  Not being very well skilled with images, it's not great.  In an ideal world we could get Mark Carson to tidy up those checkboxes.  beltzner, which would you recommend?

Comment 9

[Stefan Sitter [:ssitter]]

Comment on attachment 204237 [details]
several options

I'll vote for Option 1 (as in Sunbird) or Option 3 (checkbox with colored background).