Closed Bug 298364 Opened 20 years ago Closed 13 years ago

Implement DOM Level 3 DOMImplementation

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

I may need DOMImplementation::getFeature(...) soon.
Patch coming.
Attached patch v1Splinter Review
Attachment #186931 - Flags: review?(peterv)
Comment on attachment 186931 [details] [diff] [review]
v1

>Index: dom/src/base/nsDOMClassInfo.cpp
>===================================================================

> // includes needed for the prototype chain interfaces
> #include "nsIDOMNavigator.h"
> #include "nsIDOMBarProp.h"
> #include "nsIDOMScreen.h"
> #include "nsIDOMDocumentType.h"
> #include "nsIDOMDOMImplementation.h"
>+#include "nsIDOM3DOMImplementation.h"

You can remove

 #include "nsIDOMDOMImplementation.h"

now. And I still think this is unneeded bloat but whatever.
Attachment #186931 - Flags: review?(peterv) → review+
Comment on attachment 186931 [details] [diff] [review]
v1

Well, maybe jst could decide whether this is really bloat (and especially
unneeded bloat) ;)
Attachment #186931 - Flags: superreview?(jst)
I'm with peterv on this... Also, I would consider DOM3LS to be WONTFIX. See the
discussion on bug 155749.
Comment on attachment 186931 [details] [diff] [review]
v1

clearing sr request. I don't need this atm
Attachment #186931 - Flags: superreview?(jst)
QA Contact: ian → general
WONTFIX?
I agree. We should reinvestigate once DOM WebCore is in a more stable state and make sure that the features that stay in there stay there for a good reason.
Agree. (and about reinvestigating... need to also make sure that useful features
aren't removed from DOM in DOM WebCore)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: