298446 - Cmd-period does not stop (cancel) download, but Esc does

Status: RESOLVED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When the download manager has focus, cmd-period does not cancel the active
download.  Esc does, however.  Camino 0.9a1

There are similar cmd-period/esc parity and missing cmd-period functionality
bugs, so dupe if there should be one master bug....

Comment 1

[Samuel Sidler (old account; do not CC)]

Wevah: Do you want to look at this?

Comment 2

[Wevah (Nate Weaver)]

Josh did the DL manager, so this should probably go to him. All it really needs,
though, is an overridden -performKeyEquivalent: on a window subclass.

Comment 3

[Wevah (Nate Weaver)]

Errh, I'm dumb. It's handled in the menu! We should just have the DL manager
respond to the right selector, and change the menu item's title to "Stop
Download" when the DL window is the frontmost window.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this something that can be done along with the current DL Mgr
pause/resume/other cool stuff work?

Comment 5

[Samuel Sidler (old account; do not CC)]

(In reply to comment #4)
> Is this something that can be done along with the current DL Mgr
> pause/resume/other cool stuff work?

Should we create a 1.0 Download Manager meta bug to track the various
changes/improvements we want to make?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> Should we create a 1.0 Download Manager meta bug to track the various
> changes/improvements we want to make?

There are 19 bugs in the Downloading component and 8 with "download" in their
summaries in other components (of which I think this is the only one that really
applies to the DL Manager per se); I'd just target them appropriately, unless a
meta would help you/Jasper drive the project more successfully.  IMO, meta bugs
seem more useful for things that it's hard to come up with a good query for
(scattered components, filtering Java bugs out of other plugin bugs, etc.)

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Errh, I'm dumb. It's handled in the menu! We should just have the DL manager
> respond to the right selector, and change the menu item's title to "Stop
> Download" when the DL window is the frontmost window.

How difficult is that?

Comment 8

[Nick Kreeger]

taking

Comment 9

[Nick Kreeger]

Attachment: Proposed Patch

Since command modified keydown events don't register in ProgressDlgController, simply override the performKeyEquivalent method in ProgressView. If the event is keydown, the command key is a modifier, and if the character for the event is '.' tell our controller (ProgressViewController) to cancel.

Comment 10

[Nick Kreeger]

Attachment: Patch1 updated...

This update removes the extra space on the second line of the if statement.

Comment 11

[Nick Kreeger]

Attachment: Updated Patch

Updated patch, the previous patch would only work for the first progres view in the stack. This patch works like the double-click open feature, it posts a notification to ProgressDlgController to cancel, and PDC fires |cancel:|. |cancel:| cancels all selected downloads that are running.

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 225588 [details] [diff] [review]
Updated Patch

sr=pink

Comment 13

[Nick Kreeger]

Fixed trunk and branch