User-Agent: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+ Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+ nspr.m4 may get installed in the system's aclocal directory, so no matter what autotools versions mozilla is using, the user may still receive warnings about underquoted macro names from a recent autoconf. (At the moment, these are just warnings, but future versions of autoconf may be multi-pass, in other words, the macro would be re-expanded on a second pass generating mess.) The patch (to follow) is a trivial no brainer, so it should be easy to apply! Reproducible: Always
Chris, could you review this bug report? Thanks.
Assignee: wtchang → cls
This mistake was reported by an Ubuntu user in our bug system, at https://launchpad.net/distros/ubuntu/+source/firefox/+bug/36659 I grepped the firefox 220.127.116.11 source tree for AC_DEFUN and fixed all of the instances that that found - there were twenty.
Comment on attachment 218036 [details] [diff] [review] patch to fix some more AC_DEFUN instances Ben, if m4 macros are not your area, please ask cls to review this patch. Thanks.
Attachment #218036 - Flags: review?(benjamin)
Comment on attachment 187022 [details] [diff] [review] as mentioned in original report I checked in this nspr.m4 patch on the NSPR trunk (NSPR 4.7) and NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.9 alpha).
Status: NEW → RESOLVED
Closed: 13 years ago
OS: NetBSD → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Sorry, Ian. I gave improper attribution in the checkin comment.
Any chance this could go into the 1.8 branch? It seems very low risk.
You need to log in before you can comment on or make changes to this bug.