Closed Bug 298460 Opened 19 years ago Closed 19 years ago

Use xhtml files in content instead of html files in locale

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird1.1

People

(Reporter: p.franc, Assigned: p.franc)

Details

Attachments

(1 file, 2 obsolete files)

To make the life of localizers easier we should move both html files (credits.html and start.html) from the localization pack into messenger and localize them by entites. This is the same thing as Firefox does.
This is for credits.html. The changes are taken from credits.xhtml in browser as well as credits.dtd. Since I don't have working build enviroment, I tested this patch only by changes in the nightly build. But the jar.mn changes look pretty trivial.
Assignee: mscott → p.franc
Status: NEW → ASSIGNED
Attachment #187023 - Flags: superreview?(mscott)
Attachment #187023 - Flags: review?(gandalf)
Attachment #187023 - Flags: approval-aviary1.1a2?
Attachment #187023 - Flags: review?(gandalf) → review+
I have problems running with this patch. I get entity errors about credit.title not being defined. I don't think something is right here still
Comment on attachment 187023 [details] [diff] [review] Move credits.html to credits.xhtml You right. I forgot to add credits.dtd into mozilla/mail/locales/jar.mn I'm working on patch for both credits.html and start.html.
Attachment #187023 - Attachment is obsolete: true
This is a patch for both credits.html and start.html. After aplaying the patch you need to move mail/locales/en-US/chrome/messenger/startpage-*.png to mail/base/content/. It was tested by plathel@centrum.cz.
Attachment #187065 - Flags: superreview?(mscott)
Attachment #187065 - Flags: review?(gandalf)
Attachment #187065 - Flags: approval-aviary1.1a2?
Comment on attachment 187065 [details] [diff] [review] Move both html files I'm not sure if we want to give locale teams a way to change our URL's. (all this startpage.*URL)
Attachment #187065 - Flags: review?(gandalf) → review+
> I'm not sure if we want to give locale teams a way to change our URL's. (all > this startpage.*URL) Idealy these URLs should lead to the mozilla-europe(world).org/@ab-CD@/products/thunderbird/ for non-english builds. But for now I would allow to change them to point to some localized pages since I don't see no point to forward non-english users to kb.mozillazine.org.
Attachment #187023 - Flags: superreview?(mscott)
Attachment #187023 - Flags: approval-aviary1.1a2?
Comment on attachment 187065 [details] [diff] [review] Move both html files thanks for the patch. This one works much better
Attachment #187065 - Flags: superreview?(mscott)
Attachment #187065 - Flags: superreview+
Attachment #187065 - Flags: approval-aviary1.1a2?
Attachment #187065 - Flags: approval-aviary1.1a2+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird1.1
Patch, that landed in trunk has one glitch. Start.html file has been left in locales (for compatibility reasons, I guess), but entry telling about this file was deleted from mozilla/mail/locales/jar.mn, so this file doesn't get included in @AB_CD@.jar. Result? Someone using "old" profile with start page address set to chrome://messenger/locale/start.html gets blank page intead of start page. PS. If other graphics files had been moved from locales to messenger, why not do the same with messenger/mail_mozilla.gif? :-) It doesn't have to be in the localization pack... (I doubt it's even used by Tb)
Piotr is right. The credits.html has to stay in locales for those who had changed the start page location and then chenged it back to default (has the pref set in their old profile). I also searched LXR for mail_mozilla.gif and didn't find any occurrence of it except the jar.mn file. IMHO it should be removed
Attachment #188938 - Flags: superreview?(mscott)
Attachment #188938 - Flags: review?
Attachment #188938 - Flags: approval-l10n?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
what does the credits page have to do with the start page? They are completely unrelated
(In reply to comment #9) > Created an attachment (id=188938) [edit] > Add credits.html back and remove the gif Pavel, for the start page part I think it's a bit too late for this. Patch from bug 299104 had solved this problem out. But as for mail_mozilla.gif, if it's not used, I think it should be removed.
Attachment #188938 - Attachment is obsolete: true
> Pavel, for the start page part I think it's a bit too late for this. Patch from > bug 299104 had solved this problem out. But as for mail_mozilla.gif, if it's not > used, I think it should be removed. Gosh. Please ignore my previous comments/patch. Piotr, fill a new bug for the the gif please.
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Attachment #188938 - Flags: superreview?(mscott)
Attachment #188938 - Flags: review?
Attachment #188938 - Flags: approval-l10n?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: