Last Comment Bug 298462 - GC old code?
: GC old code?
Status: RESOLVED FIXED
:
Product: NSPR
Classification: Components
Component: NSPR (show other bugs)
: other
: x86 NetBSD
: -- trivial (vote)
: 4.6.1
Assigned To: Wan-Teh Chang
: Wan-Teh Chang
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-22 06:38 PDT by Patrick Welche
Modified: 2005-06-22 17:13 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
as mentioned in original report (884 bytes, patch)
2005-06-22 06:38 PDT, Patrick Welche
wtc: review+
Details | Diff | Review

Description Patrick Welche 2005-06-22 06:38:03 PDT
User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.8b2) Gecko/20050620 Firefox/1.0+

From the root of the mozilla source (20 June CVS)

% find . -printx | xargs grep -Hn _PRSockOptVal_t
./nsprpub/pr/src/pthreads/ptio.c:203:#define _PRSockOptVal_t char *
./nsprpub/pr/src/pthreads/ptio.c:208:#define _PRSockOptVal_t void *
%

so one more instance of #if defined(NetBSD) can go (patch about to be included..)

Reproducible: Always
Comment 1 Patrick Welche 2005-06-22 06:38:27 PDT
Created attachment 187024 [details] [diff] [review]
as mentioned in original report
Comment 2 Wan-Teh Chang 2005-06-22 17:10:41 PDT
Comment on attachment 187024 [details] [diff] [review]
as mentioned in original report

r=wtc.	I verified that the _PRSockOptVal_t type
is defined but not used.
Comment 3 Wan-Teh Chang 2005-06-22 17:13:43 PDT
Patch checked in on the NSPR trunk for NSPR 4.6.1.
Thanks a lot for the patch.

Checking in ptio.c;
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c,v  <--  ptio.c
new revision: 3.100; previous revision: 3.99
done

Note You need to log in before you can comment on or make changes to this bug.