298479 - renamed email folder to name of deleted search folder. All data lost.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[bruce korb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Thunderbird v. 1.0.2 (20050317) on Win 2K

The previously deleted search folder revived itself and the emails that had been
in the folder before the rename are now completely gone.  I fired up a DOS
prompt window and hunted around in the hidden "Application Data/Thunderbird"
hierarchy.  The data are gone.  I've done this exactly once because I do not
want to do it again.  :-}

Reproducible: Didn't try

Steps to Reproduce:
1. create a search folder, call it "foo"
2. delete it
3. create a real folder, call it "bar"
4. put messages into it
5. rename it to "foo"

Actual Results:  
The "foo" was a search-result folder containing its original results.  The
emails stored into "bar" disappeared.  gone forever.

Expected Results:  
1. the deleted search folder should have been deleted completely
2. if not, the rename should have failed in some way rather than
   reviving the dead search results.  The rename did fail.

Comment 1

[David :Bienvenu]

I'll look at this.

Comment 2

[zug_treno]

(In reply to comment #0)
> 1. the deleted search folder should have been deleted completely

Related to bug 267890?

Comment 3

[WADA:World Anti-bad-Duping Agency]

See Bug 282072 (and longlived Bug 65303), in addition to Bug 267890.

Comment 4

[bruce korb]

I would like to suggest that the "Target Milestone" be unset. 
 
Instead, the first order of business would be to understand how these  
variations on the general theme of "re-creating or renaming to a previously  
existing folder" seem to become confused.  Clearly, there must be some  
dinkleberry data left about after you have deleted something.  Find out  
what those data are, how crucial they are and how they interfere with  
newly named or renamed folders.  *Then* project a time when it can be fixed.  
Given the 4 1/2 year history and the incomplete patches, the issue must  
be a bit subtle (obscure).  :)  Cheers - Bruce  

Comment 5

[David :Bienvenu]

*** Bug 267890 has been marked as a duplicate of this bug. ***

Comment 6

[David :Bienvenu]

I have a fix for this, but I'm looking into the remaining issues in bug 65303

Comment 7

[David :Bienvenu]

Attachment: proposed fix

clear flags when folders removed.

Comment 8

[chris hofmann]

Comment on attachment 187416 [details] [diff] [review]
proposed fix

a=chofmann

Comment 9

[bruce korb]

If a fix has been applied to the sources to address the issue,
a resolution of "WORKSFORME" seems rather odd.  Nevertheless,
thank you for fixing the thing.  I'll test it myself when the
new version propagates out to a distro. - Bruce