298487 - right click - Search Web for ... opens a new tab, not a new window

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Hendrik Maryns]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

That's all there is to it.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Hendrik Maryns]

Attachment: just replaces the word window with tab

Comment 2

[Steffen Wilberg]

Indeed. Confirming and reassigning to Hendrik.

Comment 3

[Steffen Wilberg]

Comment on attachment 187037 [details] [diff] [review]
just replaces the word window with tab

r=me.

Comment 4

[Hendrik Maryns]

Ok, I can accept this bug now, but I don't have write access to the CVS root, as
far as I know ;-)  So how is this handled now?  The solution is changing only
one word, but still...

Comment 5

[Steffen Wilberg]

You'd know if you had cvs write access. :)
Once your patch has got approval, I'll check it in, and mark the bug as fixed.
You don't have to do anything. I assigned it to you because you wrote the patch,
so you'll get the credit. In the future, you can query for bugs fixed by you.
For example, I have fixed 131 bugs.

Comment 6

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml,v  <-- 
using_firebird.xhtml
new revision: 1.24; previous revision: 1.23
done

Comment 7

[Hendrik Maryns]

(In reply to comment #5)
> You'd know if you had cvs write access. :)
> Once your patch has got approval, I'll check it in, and mark the bug as fixed.
> You don't have to do anything. I assigned it to you because you wrote the patch,
> so you'll get the credit. In the future, you can query for bugs fixed by you.
> For example, I have fixed 131 bugs.

As it is fixed now, where can I `get’ this credit? ;-)

Comment 8

[Steffen Wilberg]

Here it is:
https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&emailassigned_to1=1&emailtype1=exact&email1=hendrik.maryns%40student.kuleuven.ac.be
;-)