Closed Bug 298530 Opened 20 years ago Closed 20 years ago

Incorrect dtd reference in errors.xul,

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(2 obsolete files)

bug 296566 is moving Extension Update into Extension Manager but didn't move the
errors.xul and the locale files for it into the extension manager. I'd like to
get this in for 1.1a2 if at all possible... patch coming up.
Attached patch patch (obsolete) — Splinter Review
Moves errors.xul and the associated locale files.
Assignee: nobody → rob_strong
Status: NEW → ASSIGNED
Attachment #187077 - Flags: review?(benjamin)
Comment on attachment 187077 [details] [diff] [review]
patch

I don't think this is such a good idea this late in the game. You're welcome to
*ship* it to a different location (changing the ship-location in jar.mn), but
changing the source location will break all of our localizations very close to
1.8b3 with little reason.
Attachment #187077 - Flags: review?(benjamin) → review-
Attached patch patch (obsolete) — Splinter Review
Benjamin - this just fixes the path to the dtd in errors.xul. I'll hold off on
moving the files to later. Can I also get an a= from you for this? Thanks.
Attachment #187077 - Attachment is obsolete: true
Attachment #187082 - Flags: review?(benjamin)
Attachment #187082 - Flags: approval-aviary1.1a2?
Summary: Add errors.xul, etc. to toolkit/mozapps/extensions/content → Incorrect dtd reference in errors.xul,
Attachment #187082 - Flags: review?(benjamin)
Attachment #187082 - Flags: review+
Attachment #187082 - Flags: approval-aviary1.1a2?
Attachment #187082 - Flags: approval-aviary1.1a2+
Whiteboard: [checkin needed][a+]
Patch checked in on trunk - thanks timeless - resolving fixed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed][a+]
Attachment #187082 - Attachment is obsolete: true
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: