Closed
Bug 298673
Opened 19 years ago
Closed 18 years ago
Files sent with DCC are kept locked forever
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thesoulhunter, Assigned: bugzilla-mozilla-20000923)
References
(Blocks 1 open bug)
Details
(Whiteboard: [cz-0.9.74])
Attachments
(1 file)
3.66 KB,
patch
|
samuel
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 Seems Chatzilla keeps reading access open to files it has already sent with dcc!? Reproducible: Always Steps to Reproduce: 1. DCC a file to someone... 2. Try to delete the file after dcc is done Actual Results: Its not possible to delete DCC'ed files till you close Chatzilla! Expected Results: Possible to delete files after dcc transfer finished! Tested with... Chatzilla 0.9.68a [Firefox 1.0.4/20050511] Chatzilla 0.9.68.5 [Firefox 1.0.4/20050511]
Comment 1•19 years ago
|
||
Confirming, and looking into what may cause this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•19 years ago
|
||
Silver: I think that here: http://lxr.mozilla.org/seamonkey/source/extensions/irc/js/lib/dcc.js#1229 we need to do: if (this.position >= this.size) { this.disconnect(); break; } Would that seem right to you? If it's not right, (ie, we want to wait until the receiver breaks the connection or whatever), then we should at least close the localFile similar to what CIRCDCCFileTransfer.prototype.disconnect actually does, I think.
Assignee | ||
Updated•19 years ago
|
Blocks: chatzilla1.0
Assignee | ||
Updated•18 years ago
|
Assignee: rginda → silver
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•18 years ago
|
||
This basically just makes all failed/finished code paths call dispose() which cleans up the connection (both server and client) and the local file and file stream. This has been tested to release the file handle both when a send aborts (time out) and when it finishes successfully.
Attachment #225193 -
Flags: review?(samuel)
Assignee | ||
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
Summary: Files send with DCC are locked → Files sent with DCC are kept locked forever
Version: unspecified → Trunk
Updated•18 years ago
|
Attachment #225193 -
Flags: review?(samuel) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.74]
You need to log in
before you can comment on or make changes to this bug.
Description
•