298673 - Files sent with DCC are kept locked forever

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[thesoulhunter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Seems Chatzilla keeps reading access open to files it has already sent with dcc!?

Reproducible: Always

Steps to Reproduce:
1. DCC a file to someone...
2. Try to delete the file after dcc is done

Actual Results:  
Its not possible to delete DCC'ed files till you close Chatzilla!

Expected Results:  
Possible to delete files after dcc transfer finished!

Tested with...

Chatzilla 0.9.68a  [Firefox 1.0.4/20050511]
Chatzilla 0.9.68.5 [Firefox 1.0.4/20050511]

Comment 1

[:Gijs (he/him)]

Confirming, and looking into what may cause this.

Comment 2

[:Gijs (he/him)]

Silver: I think that here:

http://lxr.mozilla.org/seamonkey/source/extensions/irc/js/lib/dcc.js#1229

we need to do:

if (this.position >= this.size)
{
   this.disconnect();
   break;
}

Would that seem right to you? If it's not right, (ie, we want to wait until the receiver breaks the connection or whatever), then we should at least close the localFile similar to what CIRCDCCFileTransfer.prototype.disconnect actually does, I think.

Comment 3

[James Ross]

Attachment: Clean up the mess in all cases

This basically just makes all failed/finished code paths call dispose() which cleans up the connection (both server and client) and the local file and file stream.

This has been tested to release the file handle both when a send aborts (time out) and when it finishes successfully.

Comment 4

[James Ross]

Checked in --> FIXED.