298699 - Theme Manager's width is no longer fixed

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

The checkin of the patch in bug 285584 didn't include "width: 20em;" (see bug
285584, comment 29) for richlistbox. This causes the theme list to flex which is
not the desired behavior (see bug 298140, comment 6 etc.). Patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

mconnor, I took the js approach to fixing this since it needs to apply to all
themes as it did before when it was set in the binding's css. There is already
js setting the window's width immediately below depending on if the window is
for themes or extensions.

Comment 2

[Robert Strong (they/them - no direct email)]

*** Bug 298878 has been marked as a duplicate of this bug. ***

Comment 3

[Benjamin Smedberg]

Comment on attachment 187231 [details] [diff] [review]
patch

Does this need to be localizable? Most of our specified widths are localizable
because of the different sizing characteristics of various languages.

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> (From update of attachment 187231 [details] [diff] [review] [edit])
> Does this need to be localizable? Most of our specified widths are localizable
> because of the different sizing characteristics of various languages.
Previously it wasn't and any text longer than the width was cropped. I believe
the proper long term solution to this is the patch in bug 292617. Even with that
the first run width should be set which this patch will do.

Comment 5

[Robert Strong (they/them - no direct email)]

checked in on trunk

Comment 6

[Ed Hume]

I know this is a bit late, but could this box be sized in relative units, such
as ex or em units?

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> I know this is a bit late, but could this box be sized in relative units, such
> as ex or em units?
The patch restores the previous behavior of setting the width to 20em. The one
difference is it does this via setting the style attribute on the element
instead of in the binding. As noted earlier a better long term solution is
available in the patch for bug 292617. As for changing it before 1.1a2 I doubt
it and I would prefer to see bug 292617 land than working on this.