298704 - richlistbox should call ensureElementIsVisible and not scrollToElement in selectedItem

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Robert Strong (they/them - no direct email)]

The init method still needs to call scrollToElement but selectedItem should only
call ensureElementIsVisible otherwise when selecting an item it will always be
scrolled to the top of the viewable list even when it is already in view.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

doron, is this an acceptable approach?

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 187235 [details] [diff] [review]
patch

r=me, you do need a toolkit r (our beloved mconnor)

Comment 3

[TimoT]

After applying this patch to my tree the extension manager returned to the
behavior it had before the fix for bug 298524 landed.

After selecting an extension and reopening the extensions manager the list is
scrolled so that the selected extension is always just out of view.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

This fixes the mistake in the previous patch. I won't be around for the next
day or two so I won't be able to pester someone for a checkin of this if it
gets approved.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 187241 [details] [diff] [review]
patch

Benjamin - this approach already has doron's approval.

Comment 6

[Robert Strong (they/them - no direct email)]

This bug fixes the Extension Manager and Download Manager to scroll everytime an
item is selected and it isn't already located at the top of the view. It is a
simple fix and would be a good thing to get in 1.1a2... I've been running the
patch as is since I submitted it and a variation of it for over a week without
any harmful side effects.

Comment 7

[Robert Strong (they/them - no direct email)]

checked in on trunk.