298715 - clean up selection code

Status: NEW

(Core :: DOM: Selection, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm going to attach a patch that does a bit of cleanup in the selection code. 
In particular:
 * clean up nsISelectionListener.idl , and remove a constant that represents "no
bits set in bitfield" (which is confusing because the constant looks just like
the bit constants)
 * Remove some unneeded mType and Get/SetType methods which are used only for an
nsTypedSelection to call its mFrameSelection to call back to itself.


Later I might also want to rename some classes -- I think the current class
names are extremely confusing.  I've been thinking of:

  nsISelectionController -> nsISelectionContainer

  nsSelection -> nsSelectionManager  (or nsSelectionList or Set?)
  NS_NewSelection -> NS_NewSelectionManager
  nsIFrameSelection -> nsISelectionManager

  nsTypedSelection -> nsSelection or nsDOMSelection

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch #1

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, I should fix up some of the file locations after the layout file
reorganization:

content/base/public/nsISelection.idl
content/base/public/nsISelectionController.idl
content/base/public/nsISelectionDisplay.idl
content/base/public/nsISelectionListener.idl
content/base/public/nsISelectionPrivate.idl
layout/base/nsIFrameSelection.h
layout/base/nsISelectionImageService.h
layout/generic/nsSelection.cpp


(And also fix nsStyleConsts.h while I'm doing this.)

Comment 3

[Mats Palmgren (inactive)]

FYI, there is also bug 165870.

Comment 4

[Marc Liddell]

Attachment: updated patch #1

This is an updated version of the patch. I'm not exactly sure what should be done with it.

If anyone wants me to do any of the renaming in comment 0 or any new kind of renaming scheme I can do that...