298729 - "error: 'struct AliasRecord' has no member named 'aliasSize'" when compiling

Status: RESOLVED EXPIRED

(Firefox Build System :: General, defect)

Description

[Simon Kornblith]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050624 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050624 Firefox/1.0+

When I first tried to build Mozilla on 10.4 with XCode 2.1 and GCC 4, I got the
following error:

nsLocalFileOSX.cpp:1341: error: 'struct AliasRecord' has no member named 'aliasSize'
nsLocalFileOSX.cpp:1346: error: 'struct AliasRecord' has no member named 'aliasSize'

The Universal Binary Programming Guidelines dictate we must now use
GetAliasSizeFromPtr rather than the AliasSize field of an AliasRecord. This is a
rather simple fix.

Reproducible: Always

Steps to Reproduce:
1. Install XCode 2.1.
2. Use GCC 4.0.
3. Compile Firefox from CVS.
Actual Results:  
nsLocalFileOSX.cpp:1341: error: 'struct AliasRecord' has no member named 'aliasSize'
nsLocalFileOSX.cpp:1346: error: 'struct AliasRecord' has no member named 'aliasSize'

Expected Results:  
Compilation should proceed, although there are some other deprecated functions
in the same file.

Comment 1

[Simon Kornblith]

Attachment: Proposed Patch

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.