298736 - mouse event caught when hitting stop button

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Andrew Schultz]

With linux suite trunk build 2005062305 (Venkman 0.9.83), if I hit the "stop"
button, it immeadiately stops, apparently catching the mouse event of hitting
stop, and loads an empty venkman.xul in a tab in the Source Code view.  After
hitting the continue button (and then stop again), things work ok.

I have "Exclude browser files" checked.

Comment 1

[James Ross]

Attachment: Delay stop so that Gecko has a chance to clean up first

This just delays the enabling of the stop so that all events and stuff should be done with. In theory, the venkman.xul stop should be ignored for "Exclude Browser Files", but that's for another bug. This patch also stops you ending up in button.xml with that option unchecked.

Comment 2

[Robert Ginda]

Comment on attachment 223478 [details] [diff] [review]
Delay stop so that Gecko has a chance to clean up first

Can't we just setTimeout to 1, to get us into a new stack?

Comment 3

[James Ross]

Probably; I'm not one for trusting Gecko that much. I'll see how well it works with 1ms...

Comment 4

[James Ross]

Attachment: Only delay 1ms

Comment 5

[:Gijs (he/him)]

Comment on attachment 243176 [details] [diff] [review]
Only delay 1ms

Hacky, but otherwise mighty fine, and I have no better ideas.

r=gijs

Comment 6

[:Gijs (he/him)]

James, could you check this in?

Comment 7

[:Gijs (he/him)]

Hey James, I'm sorry for being repetitive, but I know you don't like me checking in your patches, so I would like to ask again if you could please check this in. Thanks! :-)

Comment 8

[James Ross]

You really ought to make sure people you're talking to are CCed. :P

Comment 9

[James Ross]

This was checked in on 20th January. I forgot to close the bug, I guess.

Checked in --> FIXED.