298766 - nesting of the page setup settings documentation is screwed

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Hendrik Maryns]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Look at the above page as html.  The menu about print preview is indented very
weirdly.  I guess the </li> end tag on line 421 should be moved to the end of
the paragraph.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Hendrik Maryns]

Attachment: reformats the list, adding moving a few </ul> and </li>s

I moved around a bit with the tags, and I think they're correct now.

I wouldn't mind a reformatting of the file, but I'll leave that to the one
checking in the patch...

Comment 2

[Hendrik Maryns]

Why can't I assign this bug to myself? It says only thus empowered people are
able to do that, or the owner or submitter.  As there is no owner and I am the
submitter, I don't see the problem.

Comment 3

[Steffen Wilberg]

Looks like you need the "editbugs" bugzilla privilege. Ask Gerv to grant it to
you, because you're writing patches and would like to assign bugs to yourself.

Comment 4

[Steffen Wilberg]

Comment on attachment 187282 [details] [diff] [review]
reformats the list, adding moving a few </ul> and </li>s

r=me, indenting needs to be fixed before checkin.

Comment 5

[Hendrik Maryns]

(In reply to comment #4)
> (From update of attachment 187282 [details] [diff] [review] [edit])
> r=me, indenting needs to be fixed before checkin.

Will you do this?  I like the indentation that XMLBuddy, an Eclipse plugin
gives, and that makes it only a matter of Ctrl+Shift+F, but if you can do it
just as easy, feel free!

(In reply to comment #3)
> Looks like you need the "editbugs" bugzilla privilege. Ask Gerv to grant it to
> you, because you're writing patches and would like to assign bugs to yourself.

Where can I find this Gerv?

Comment 6

[Steffen Wilberg]

I'd appreciate a patch fixing the indentation, provided that it doesn't modify
every single line in the file.

http://www.gerv.net/hacking/before-you-mail-gerv.html

Comment 7

[Hendrik Maryns]

(In reply to comment #6)
> I'd appreciate a patch fixing the indentation, provided that it doesn't modify
> every single line in the file.
> 
> http://www.gerv.net/hacking/before-you-mail-gerv.html

I just did a CVS update, and it seems like you already applied the patch, only
the formatting is not nice.  I have a patch which redoes the formatting of this
part of the page specifically, if you want, but that's all it does.

Comment 8

[Steffen Wilberg]

> I just did a CVS update, and it seems like you already applied the patch
I didn't. I checked in your patches for the other two bugs, but not this one.
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml
I still get your patch when doing cvs diff -u.

Comment 9

[Hendrik Maryns]

Attachment: same patch with indentation

I underestimated the power of CVS!  The file was marked changed, but that was
because it was merged with the changes you applied for those other bugs.

Anyway, it is basically the same patch, I just let XMLBuddy reformat the whole
table.	The rest shouldn't be altered.

Comment 10

[Benjamin Smedberg]

Comment on attachment 187558 [details] [diff] [review]
same patch with indentation

a=bsmedberg for landing today (6/29)

Comment 11

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml,v  <-- 
using_firebird.xhtml
new revision: 1.25; previous revision: 1.24
done