298769 - In </chrome/US.jar>, 2 "Error: no element found"

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050625] (nightly) (W98SE)

First (Browser) startup:

{{
Error: no element found
Source File: jar:resource:///chrome/US.jar!/locale/US/editor-region/contents.rdf
Line: 1

Error: no element found
Source File: jar:resource:///chrome/US.jar!/locale/US/editor-region/manifest.rdf
Line: 1
}}

Comment 1

[[e-mail]]

Looks like fallout from bug 286108 - locale/US/editor-region/contents.rdf and
region.properties got put into comm.jar instead of US.jar by mistake.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Looks like fallout from bug 286108 - locale/US/editor-region/contents.rdf and
> region.properties got put into comm.jar instead of US.jar by mistake.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050625] (nightly) (W98SE)

'content/' file is in <comm.jar>,
'locale/' files are in <en-US.jar>.

Workaround:
This change to <installed-chrome.txt> (and deleting <chrome.rdf> to be sure)
fixes this bug
{{
-locale,install,url,jar:resource:/chrome/US.jar!/locale/US/editor-region/
+locale,install,url,jar:resource:/chrome/en-US.jar!/locale/en-US/editor-region/
}}

Then I don't know if the files need to be moved, or the chrome registration
updated: I leave it to you.

Comment 3

[[e-mail]]

(In reply to comment #2)
>'content/' file is in <comm.jar>,
>'locale/' files are in <en-US.jar>.
Yes, but -region files go in <US.jar>

Comment 4

[Robert Kaiser]

Attachment: patch: move region locale back to US.jar

This should do it. SeaMonkey still only supports building en-US, so it's OK to
hardcode the file to US.jar here for now (I'd love to get rid of the seperate
region and platforms packs one time anyways, then we also can get rid of that
hardcoding).

For now, we need the files in the old region/content pack location and this
moves them back there.

Comment 5

[[e-mail]]

Comment on attachment 189425 [details] [diff] [review]
patch: move region locale back to US.jar

The zip path is still locale/en-US/editor-region

Comment 6

[Robert Kaiser]

Attachment: patch v2: also change path back to US [Checked in: Comment 8]

Argh, sure, have to adjust the path as well... Done in this version...

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 189460 [details] [diff] [review]
patch v2: also change path back to US
[Checked in: Comment 8]

'approval1.8b4=?': (SeaMonkey only)
Trivial installer fix, no risk.

Comment 8

[Robert Kaiser]

checked in, this should be FIXED now ;-)

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050720 SeaMonkey/1.0a]
(nightly) (W98SE)

V.Fixed.