298816 - Javascript error "redeclaration of const imgICache" in contentAreaUtils.js

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Following error is reported on startup of Thunderbird:

Error: redeclaration of const imgICache
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 232

Patch will follow.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v1

Moving several constant declarations into the functions where they are used. No
need to declare them outside while they are used only once.

Comment 2

[Karsten Düsterloh]

Comment on attachment 187340 [details] [diff] [review]
patch v1

> function saveImageURL(aURL, aFileName, aFilePickerTitleKey, aShouldBypassCache,
>                       aReferrer)
> {
>+  const imgICache = Components.interfaces.imgICache;

This constant is used exactly once and is thus pretty useless. Use its value
directly when calling getService.

>-const SAVEMODE_FILEONLY      = 0x00;

This is used in more than one function!

> function appendFiltersForContentType(aFilePicker, aContentType, aFileExtension, aSaveMode)
> {
>+  const SAVEMODE_FILEONLY      = 0x00; // We have no DOM, and can only save the URL as is.

... not only here!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v2 - only tb fixes

The window messageWindow.xul includes the contentAreaUtils.js twice. Further
messenger.xul includes the overlay contentAreaContextOverlay.xul which self
includes the contentAreaUtils.js.

Comment 4

[Scott MacGregor]

Comment on attachment 187343 [details] [diff] [review]
patch v2 - only tb fixes

thanks for the patch