298820 - nsIScriptableUConv should use ACString

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

it would be nice if nsIScriptableUnicodeConverter would use ACString in its
signatures, so that if someone actually can get hold of a string with null
bytes, they can convert it successfully.

This does not affect JS compatibility.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Jungshik Shin]

Comment on attachment 187344 [details] [diff] [review]
patch

r=jshin

thanks !

ConvertFromByteArray(NS_REINTERPRET_CAST(const PRUint8*, aSrc),
>-                              strlen(aSrc),
>+  nsACString::const_iterator i;
>+  aSrc.BeginReading(i);
>+  return ConvertFromByteArray(NS_REINTERPRET_CAST(const PRUint8*, i.get()),
>+                              aSrc.Length(),
>                               _retval);

How about using darin's idiom? :-)

const PRUint8* i =
  NS_REINTERPRET_CAST(const PRUint8*, aSrc.BeginReading()); 
ConvertFromByteArray(i, aSrc.Length(), _retval);

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 187344 [details] [diff] [review]
patch

  NS_REINTERPRET_CAST(const PRUint8*, aSrc.BeginReading()); 

I'd love to, but that requires an nsCString, not an nsACString.

Comment 4

[Darin Fisher]

Comment on attachment 187344 [details] [diff] [review]
patch

You could optimize this code to avoid the buffer copies by using SetLength +
BeginWriting on nsACString,  but I'm not sure it's worth it.

sr=darin

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 187344 [details] [diff] [review]
patch

yeah, not sure either. maybe as a followup patch.

Low risk patch to change the type accepted by a function to allow passing all
kinds of binary data.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in intl/uconv/idl/nsIScriptableUConv.idl;
/cvsroot/mozilla/intl/uconv/idl/nsIScriptableUConv.idl,v  <-- 
nsIScriptableUConv.idl
new revision: 1.10; previous revision: 1.9
done
Checking in intl/uconv/src/nsScriptableUConv.cpp;
/cvsroot/mozilla/intl/uconv/src/nsScriptableUConv.cpp,v  <--  nsScriptableUConv.cpp
new revision: 1.17; previous revision: 1.16
done