298842 - make the temp file part of nsITransfer

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Mike Connor [:mconnor]]

per discussion with biesi, lets make the temp file a part of nsITransfer instead
of making all consumers implement observers, since they'll need this file

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 187362 [details] [diff] [review]
patch

thanks!

Comment 3

[Darin Fisher]

Comment on attachment 187362 [details] [diff] [review]
patch

>Index: uriloader/base/nsITransfer.idl

>-[scriptable, uuid(0721AAF2-28AC-46cd-BCFA-5F8CA2A8B99B)]
>+[scriptable, uuid(23c51569-e9a1-4a92-adeb-3723db82ef7c)]
> interface nsITransfer : nsIWebProgressListener2 {

does it make sense to rev the IID of nsIDownload?

so can the temp file be null when uploading?  iirc, nsITransfer was
created to support uploading as well as downloading.  in the case
where we are uploading, the target URI is not a file:// URI.

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

yeah, it can be null in other cases too (webbrowserpersist downloads). I did
document that it can be null.

I'll change the IID of nsIDownload.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 187362 [details] [diff] [review]
patch

trivial patch, adds an argument to a function, very low risk.

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 187362 [details] [diff] [review]
patch

a=shaver with IID rev.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v1.1

merged to trunk + nsIDownload IID change

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in.