298851 - This example worked with V1.0.2 but since does not work with 1.0.3+ . Works with IE

Status: RESOLVED DUPLICATE of bug 293933

(Core :: JavaScript Engine, defect)

Description

[Marcwolf]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

This pages worked fine in 1.0.2 and also runs ok in IE(5,6).
You can view the source of this by clicking the SOURCE link. The exact code that
is failing is 

	if (typeof(win.DIF_mainHandlersAdded)=="undefined" || !win.DIF_mainHandlersAdded) {
		// This is done in a funky way to make Netscape happy
		with (win) { 
*****			eval("function OnMouseDownHandler(evt) {
if(typeof(evt)=='undefined'){evt=event;}"+topRefStr+".parent.DIF_begindrag(evt,
"+topRefStr+") }");
*****			eval("document.onmousedown = OnMouseDownHandler;");
			eval("function OnMouseUpHandler(evt) {
if(typeof(evt)=='undefined'){evt=event;}"+topRefStr+".parent.DIF_enddrag(evt,
"+topRefStr+") }");
			eval("document.onmouseup = OnMouseUpHandler;");
			eval("function OnMouseMoveHandler(evt) {
if(typeof(evt)=='undefined'){evt=event;}"+topRefStr+".parent.DIF_iframemove(evt,
"+topRefStr+") }");
			eval("document.onmousemove = OnMouseMoveHandler;");
			win.DIF_handlersAdded = true;


Where the EVAL function (marked by ****) is not running.  The JS Console brings
up a error of

Error: function eval must be called directly, and not by way of a function of
another name.
Source File: http://www.mattkruse.com/javascript/dragiframe/source/dragiframe.js
Line: 115

This has only happened since V1.0.3 

Reproducible: Always

Steps to Reproduce:
1. Open the URL in Firefox
2. Click on one of the Iframes to drag it
3. Open the JS Console and view the error

Actual Results:  
Nothing happens.  Not expected result The page does not process any of the
expected mouse events

Expected Results:  
When the mouse is positioned over one of the iframes the cursor should change.
Then clicking and dragging the Iframe it should around the page.

The code dynamically add's JS functions to the IFrame from the parent. This is
initiated by a single call in the Iframes Body Onload. 

We use this functionalty on our sites. Most of our sites are behind a login so
we cannot give them out however the original example (given link) is where we
got the code from.

I am also approaching the author on this issue however he has not result as
yet..  I feel that this is more a firefox issue as the code was working in
previous version prior to 1.0.3

Comment 1

[Bill Gianopoulos [:WG9s]]

Confirming this behaviour with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8b2) Gecko/20050625 Firefox/1.0+.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This was broken by the checkin for bug 217195 (bug 223041).

The question is whether or not this use case is valid.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=jsobj.c&branch=AVIARY_1_0_1_20050124_BRANCH&root=/cvsroot&subdir=mozilla/js/src&command=DIFF_FRAMESET&rev1=3.155.2.1.4.6.2.4&rev2=3.155.2.1.4.6.2.5

Comment 3

[Brendan Eich [:brendan]]

*** This bug has been marked as a duplicate of 293933 ***