If the download manager window is open it should be nice to have cmd-shift-d close the window (like Mail does wind cmd-0 and the activity window) otherwise open the download manager window.
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Right now it focuses/brings to front the Download Manager. Are people who let it get hidden and use the keystroke to bring it back to the front going to be upset?
(In reply to comment #2) > Right now it focuses/brings to front the Download Manager. Are people who let > it get hidden and use the keystroke to bring it back to the front going to be upset? Yes. :) I could deal with it hiding the window if it's already the main window, but I'd expect it to be brought to the front if it's behind another window. (I find myself relying on this behavior quite a bit.)
This makes it so that if the frontmost window is the downloads window, it closes it, and otherwise it works just like it does currently.
Assignee: mikepinkerton → stridey
Status: NEW → ASSIGNED
Attachment #227185 - Flags: review?(mozilla)
Uses performClose instead of close. Per IRC, this can cause all windows to close if the item is chosen from the menu with option held, but that would be extremely unlikely, and it's not trigger-able through the keyboard shortcut, so we're safe here.
Comment on attachment 230369 [details] [diff] [review] calls performClose instead r=me, with the isKeyWindow -> isMainWindow change
Attachment #230369 - Flags: review?(mozilla) → review+
Comment on attachment 230373 [details] [diff] [review] r=Wevah patch sr=pink
Attachment #230373 - Flags: superreview?(mikepinkerton) → superreview+
Fixed trunk and branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.