cmd-shift-d should both open and close the Download Manager window

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: dereks, Assigned: froodian)

Tracking

({fixed1.8.1})

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

14 years ago
If the download manager window is open it should be nice to have cmd-shift-d
close the window (like Mail does wind cmd-0 and the activity window) otherwise
open the download manager window.

Comment 1

14 years ago
Confirming
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Right now it focuses/brings to front the Download Manager.  Are people who let
it get hidden and use the keystroke to bring it back to the front going to be upset?
(In reply to comment #2)
> Right now it focuses/brings to front the Download Manager.  Are people who let
> it get hidden and use the keystroke to bring it back to the front going to be
upset?

Yes. :)

I could deal with it hiding the window if it's already the main window, but I'd
expect it to be brought to the front if it's behind another window. (I find
myself relying on this behavior quite a bit.)
(Assignee)

Comment 4

13 years ago
This makes it so that if the frontmost window is the downloads window, it closes it, and otherwise it works just like it does currently.
Assignee: mikepinkerton → stridey
Status: NEW → ASSIGNED
Attachment #227185 - Flags: review?(mozilla)
(Assignee)

Comment 5

13 years ago
Posted patch calls performClose instead (obsolete) — Splinter Review
Uses performClose instead of close.  Per IRC, this can cause all windows to close if the item is chosen from the menu with option held, but that would be extremely unlikely, and it's not trigger-able through the keyboard shortcut, so we're safe here.
Attachment #227185 - Attachment is obsolete: true
Attachment #230369 - Flags: review?(mozilla)
Attachment #227185 - Flags: review?(mozilla)
Comment on attachment 230369 [details] [diff] [review]
calls performClose instead

r=me, with the isKeyWindow -> isMainWindow change
Attachment #230369 - Flags: review?(mozilla) → review+
(Assignee)

Comment 7

13 years ago
Posted patch r=Wevah patchSplinter Review
Attachment #230369 - Attachment is obsolete: true
Attachment #230373 - Flags: superreview?(mikepinkerton)
Comment on attachment 230373 [details] [diff] [review]
r=Wevah patch

sr=pink
Attachment #230373 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Updated

13 years ago
Whiteboard: [needs checkin]

Comment 9

13 years ago
Fixed trunk and branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.