298932 - cmd-shift-d should both open and close the Download Manager window

Status: RESOLVED FIXED

(Camino Graveyard :: Accessibility, enhancement)

Description

[Derek Schrock]

If the download manager window is open it should be nice to have cmd-shift-d
close the window (like Mail does wind cmd-0 and the activity window) otherwise
open the download manager window.

Comment 1

[Jasper]

Confirming

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Right now it focuses/brings to front the Download Manager.  Are people who let
it get hidden and use the keystroke to bring it back to the front going to be upset?

Comment 3

[Wevah (Nate Weaver)]

(In reply to comment #2)
> Right now it focuses/brings to front the Download Manager.  Are people who let
> it get hidden and use the keystroke to bring it back to the front going to be
upset?

Yes. :)

I could deal with it hiding the window if it's already the main window, but I'd
expect it to be brought to the front if it's behind another window. (I find
myself relying on this behavior quite a bit.)

Comment 4

[froodian (Ian Leue)]

Attachment: Does What Wevah Could Deal With

This makes it so that if the frontmost window is the downloads window, it closes it, and otherwise it works just like it does currently.

Comment 5

[froodian (Ian Leue)]

Attachment: calls performClose instead

Uses performClose instead of close.  Per IRC, this can cause all windows to close if the item is chosen from the menu with option held, but that would be extremely unlikely, and it's not trigger-able through the keyboard shortcut, so we're safe here.

Comment 6

[Wevah (Nate Weaver)]

Comment on attachment 230369 [details] [diff] [review]
calls performClose instead

r=me, with the isKeyWindow -> isMainWindow change

Comment 7

[froodian (Ian Leue)]

Attachment: r=Wevah patch

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 230373 [details] [diff] [review]
r=Wevah patch

sr=pink

Comment 9

[Nick Kreeger]

Fixed trunk and branch.