Closed
Bug 298937
Opened 19 years ago
Closed 19 years ago
TARGET_XPCOM_ABI not set in Mac OSX builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file, 1 obsolete file)
|
697 bytes,
patch
|
cls
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
TARGET_XPCOM_ABI not set in Mac OSX builds It turns out that this is because CPU_ARCH is not getting set, and it is not getting set because $(uname -m) evaluates to "Power Macintosh" instead of "powerpc", which is what configure.in expects. I've created a simple patch for this, but Chase noted that $(uname -p) does indeed result in "powerpc". However, I'm not sure that we can use that since we have a bit of a chicken-and-the-egg problem here. This bug is blocking the new update service.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #187418 -
Flags: review?(benjamin)
|
||
Comment 2•19 years ago
|
||
Darin, I'm not sure that approach will be compatible with the x86 Macs. How about fixing up OS_TEST to be `uname -p` on Darwin as is done with a variety of other OSes?
Attachment #187428 -
Flags: review?(darin)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #187418 -
Attachment is obsolete: true
Attachment #187418 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 187428 [details] [diff] [review] More portable? (untested) Yeah, I like this patch better. Thanks!
Attachment #187428 -
Flags: superreview?(benjamin)
Attachment #187428 -
Flags: review?(darin)
Attachment #187428 -
Flags: review+
|
||
Comment 4•19 years ago
|
||
Comment on attachment 187428 [details] [diff] [review] More portable? (untested) r=me, though I would really like cls to comment if possible.
Attachment #187428 -
Flags: superreview?(benjamin) → superreview+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #187428 -
Flags: review+ → review?(cls)
Attachment #187428 -
Flags: review?(cls) → review+
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 187428 [details] [diff] [review] More portable? (untested) I'll land this.
Attachment #187428 -
Flags: approval1.8b3+
|
|
||
Comment 6•19 years ago
|
||
Checked in for 1.8b3
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•