Closed
Bug 298967
Opened 20 years ago
Closed 20 years ago
Incorporate latest feedback into role and states table
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file)
|
5.69 KB,
patch
|
parente
:
review+
tor
:
superreview+
mkaply
:
approval1.8b3+
|
Details | Diff | Splinter Review |
The attributes selected and checked should act like expanded, in that setting them to "false" is different from not having them. checked="false" means checkable, no checked attribute means not checkable selected="false" means selectable, no selected attribute means not selectable Putting menuitemcheckable back in for 2 reasons: 1. to be symmetrical menuitemradio which we need 2. because both it and menuitemradio can't have a submenu (no haspopup support)
| Assignee | ||
Comment 1•20 years ago
|
||
Attachment #187473 -
Flags: superreview?(bzbarsky)
Attachment #187473 -
Flags: review?(bzbarsky)
| Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 187473 [details] [diff] [review] Simple table change to implement tweaks Another small patch. Bz is gone for a few more days.
Attachment #187473 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #187473 -
Flags: superreview?(bzbarsky)
Attachment #187473 -
Flags: review?(parente)
Attachment #187473 -
Flags: review?(bzbarsky)
Comment on attachment 187473 [details] [diff] [review] Simple table change to implement tweaks Do ATs expect grid cells and headers to be selectable but not list items? Seems like a list is a degenerate (1D) table and should behave as such.
Attachment #187473 -
Flags: review?(parente) → review+
| Assignee | ||
Comment 4•20 years ago
|
||
Good catch. List item should have used the same rules as grid in terms of selected/selectable. The AT's should only expect that something is selectable if it says it is, not based on the role.
Attachment #187473 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
| Assignee | ||
Updated•20 years ago
|
Attachment #187473 -
Flags: approval1.8b3?
Comment 5•20 years ago
|
||
Comment on attachment 187473 [details] [diff] [review] Simple table change to implement tweaks a=mkaply
Attachment #187473 -
Flags: approval1.8b3? → approval1.8b3+
| Assignee | ||
Comment 6•20 years ago
|
||
Checking in src/base/nsAccessible.cpp; /cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v <-- nsAccessible.cpp new revision: 1.155; previous revision: 1.154 done Checking in src/base/nsAccessible.h; /cvsroot/mozilla/accessible/src/base/nsAccessible.h,v <-- nsAccessible.h new revision: 1.66; previous revision: 1.65 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•