298985 - wrong comment in l10n resource pref-addressing.dtd LDAP

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Hidehiro Kozawa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020826
Build Identifier: 

comment below is wrong.
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/prefs/resources/locale/en-US/pref-addressing.dtd#46
Patch of Bug 80304 made this comment bug.(check in at 1.13
srilatha%netscape.com	2001-05-16 17:43	 	Modified the Addressing pref panel to
fit in the pref window. bug# 80304. r=mohanb, sr=sspitzer)

We can fix it soon for l10n people.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Hidehiro Kozawa]

Attachment: Patch

Comment 2

[Robert Kaiser]

Comment on attachment 187493 [details] [diff] [review]
Patch

Erm, sorry, but why not remove the note completely? Every L10n note should
reference the entity it belongs to, so removing just that is clearly wrong,
theoretically it should point to the correct entity. Only that there's no
entity there which even contains "LDAP", so the L10n note should just go away.

Comment 3

[Hidehiro Kozawa]

(In reply to comment #2)
> (From update of attachment 187493 [details] [diff] [review] [edit])
> Erm, sorry, but why not remove the note completely? Every L10n note should
> reference the entity it belongs to, so removing just that is clearly wrong,
> theoretically it should point to the correct entity. Only that there's no
> entity there which even contains "LDAP", so the L10n note should just go away.
> 

Oh, Sorry.
Every L10n note should not reference the entity it belongs to.
see
http://lxr.mozilla.org/seamonkey/source/mailnews/extensions/mdn/resources/locale/en-US/msgmdn.properties#37

but no LDAP below no :P

I remove all.

Comment 4

[Hidehiro Kozawa]

Attachment: Patch V2

Comment 5

[Jungshik Shin]

Comment on attachment 187599 [details] [diff] [review]
Patch V2

r=jshin

Comment 6

[Hidehiro Kozawa]

Oh I found Bug 79249.

I shoud not only remove it but add below...

http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/locale/en-US/am-addressing.dtd#5
http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/am-addressing.dtd#5

Comment 7

[Hidehiro Kozawa]

oops
new addressingText.label has no 'LDAP'.

attachment 187599 [details] [diff] [review] is still alive...

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is fixed by bug 294140 already.

Comment 9

[David :Bienvenu]

Comment on attachment 187493 [details] [diff] [review]
Patch

clearing obsolete request