298987 - firefox -chrome chrome://... opens unresizable window

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Bob Clary [:bc] (inactive)]

Trunk firefox builds will open a window with a disabled maximize widget and
without the ability to resize the window by dragging its edges. This is not the
case with 1.0.x firefox builds.

To reproduce: launch firefox from the command line as

firefox -chrome chrome://browser/content

I think this was fall out from the appShell to appStartup change.

Comment 1

[Benjamin Smedberg]

Actually it's probably fallout from the command-line-handling rewrite.

Comment 2

[Benjamin Smedberg]

What platforms did you notice this on? The relevant window-opening code is
http://lxr.mozilla.org/mozilla/source/browser/components/nsBrowserContentHandler.js#236

Comment 3

[Bob Clary [:bc] (inactive)]

Windows XP. 

Comment 4

[Benjamin Smedberg]

Attachment: Always add an argstring (even if empty) so that the "dialog=no" applies

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 199333 [details] [diff] [review]
Always add an argstring (even if empty) so that the "dialog=no" applies

Wouldn't removing the |if (args)| at
http://lxr.mozilla.org/seamonkey/source/browser/components/nsBrowserContentHand
ler.js#134 be better? As it is, you're basically setting |argstring.data =
argstring| in openWindow() (this isn't the nsIWindowWatcher openWindow).

Comment 6

[Benjamin Smedberg]

Comment on attachment 199333 [details] [diff] [review]
Always add an argstring (even if empty) so that the "dialog=no" applies

No, but I should just pass an empty string.

Comment 7

[Benjamin Smedberg]

Attachment: Always add an argstring (even if empty) so that the "dialog=no" applies, rev. 2

Comment 8

[Benjamin Smedberg]

Fixed on trunk; I'd like to get this on branch too.

Comment 9

[Benjamin Smedberg]

Fixed on 1.8 branch.