299031 - Necko does not honor HTTP 410 Gone

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[cv2pf6ip50]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

If our server returns HTTP 410, Firefox ignores it and treats it as if it was 
404. 

Our server returns 410 for the /favicon.ico file. Despite that Firefox keeps 
requesting the file while the user continues browsing other pages on the same 
site (e.g. domainc.com/index.html and then domain.com/some.html).

410 means _permanently_ gone (unlike 404) so the file should NOT be requested 
again. In the case of favicon.ico, it is Firefox that makes the request (not 
the user or any external linking entity). So it is Firefox who has to remember 
that it should not request the file again (at least for the session).


Reproducible: Always

Comment 1

[Josh Birnbaum]

->Core:Networking:HTTP

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

there are two issues here...
1) favicons should cache nonexistance (not a necko issue)
2) 410 Gone should make necko not re-request the page (a necko issue)

Comment 3

[Darin Fisher]

-> default owner

Comment 5

[Patrick McManus [:mcmanus]]

I've adjust the heuristic approach for 410 to allow more caching (because I agree that 410 is a strong implicit signal).. explicit response headers should still be honored.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3da4a1c6b67e

Comment 6

[Patrick McManus [:mcmanus]]

Attachment: heuristic cache rule for 410 should be longer

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 8701191 [details] [diff] [review]
heuristic cache rule for 410 should be longer

Review of attachment 8701191 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/test_cacheflags.js
@@ +280,5 @@
>    var test = gTests.shift();
>    test.run();
>  }
>  
> +function handler(okStatus, metadata, response) {

s/okStatus/httpStatus/ ?

Comment 8

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4c1a14f442bbcb584ac1eaeb7c1fd95d373313
Bug 299031 - heuristic cache rule for 410 should be longer r=mayhemer

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed4c1a14f442