299032 - Input not validated on load

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

We are having the problem again where controls may not be properly marked
invalid on load.  It looks like if we include the MIP of 'required' on the bind,
then we'll go through the nsXFormsModelElement::ValidateNode code, otherwise we
won't.  The MDG's recalculate doesn't seem to be sending back any changed nodes
upon document load whereas in the case of the 'required' MIP being present, then
it does.

Comment 1

[aaronr]

Attachment: testcase

Both inputs should be marked red, but only the one with the 'required' MIP is. 
Under Novell and formsPlayer, both are marked red.

Comment 2

[Doron Rosenberg (IBM)]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsXFormsModelElement.cpp&branch=&root=/cvsroot&subdir=mozilla/extensions/xforms&command=DIFF_FRAMESET&rev1=1.56&rev2=1.57

Caused by bug 283004 - before, AddMIP was called for eModel_type, currently it
isn't.

Comment 3

[Doron Rosenberg (IBM)]

Attachment: patch - put back mip command for

Comment 4

[Allan Beaufour]

Comment on attachment 187545 [details] [diff] [review]
patch - put back mip command for 

Oooops, this one was my bad. Sorry.

>+          rv = mMDG.AddMIP(eModel_constraint, nsnull, nsnull, PR_FALSE, node, 1,
>+                           1);

Check the return value. With that r+ from me.

Comment 5

[Doron Rosenberg (IBM)]

checked in