299077 - no Clear button in the Passwords tab of the Privacy panel of Preferences

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Hendrik Maryns]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl-NL; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Hi, the document says "You can click the <em>Clear</em> button on each tab to
clear that information."  Which is not accurate, as there is no such button in
the passwords tab.

Reproducible: Always

Steps to Reproduce:



Expected Results:  
Either it should be `most', the sentence should be deleted, or a button should
be added in the passwords tab (more preferably something like reinitialise
master password)

Comment 1

[Hendrik Maryns]

Also, the button is named Clear X for an appropriate X on (almost ;-) each tab,
so there should be something like `the corresponding <strong>Clear</strong> button'.

Comment 2

[Hendrik Maryns]

This is about the privacy panel, sorry

Comment 3

[Steffen Wilberg]

Attachment: patch for this bug and bug 299078

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 188097 [details] [diff] [review]
patch for this bug and bug 299078

> <h2 id="privacy_options">Privacy &pref.pluralCaps;</h2>
> 
>   <p>The Privacy panel contains &pref.plural; related to your privacy. As you
>     browse the web, information on where you have been, what pages you have
>-    visited, etc. are stored here. You can click the <em>Clear</em> button on
>-    each tab to clear that information.</p>
>+    visited, etc. are stored here. You can click the corresponding <em>Clear</em>
>+    button on each but the Passwords tab to clear that information.</p>

To a large extent I really think this is something that should be ignored, but
there's a small chance we can make the wording more accurate and at most
negligibly worse than it is now.  The proposed change does make for more
accurate wording, but it also screams the question, "Why is the UI
inconsistent?"	A way that doesn't push the issue to the front as much might go
like this (in place of everything from "You can" to end of paragraph):

You can clear saved passwords in the Passwords tab by clicking <em>View Saved
Passwords</em> and then clicking the <em>Remove All</em> button in the Password
Manager dialog.  For the other tabs, click the corresponding <em>Clear</em>
button to clear that tab's information.

The obvious regression from this is that the text bloats up quite a bit; this
is why I'm very close to just ignoring this issue.  However, I think this can
work well enough to go in.  If you can come up with something better, I'm all
ears.

Feel free to split this patch and commit the "View Download History" part if
you want; I think it looks pretty good, and it'd be r+ if it were its own
patch.	The "Clear" part's all that needs more consideration.

Comment 5

[Steffen Wilberg]

Attachment: patch v1.1

No no, let's keep this together, I'm already juggling with 5 or so patches
right now :)

I think the missing Clear button on the Passwords tab is a measure to prevent
accidential dataloss. So I've added a sentence starting with "If you really
want to delete all your Passwords at once". That implies "you normally don't
want to do that", which should explain why the Clear button is missing.

Comment 6

[Jeff Walden (gone starting June 8)]

Comment on attachment 188247 [details] [diff] [review]
patch v1.1

I disagree with your assessment of the why behind "Clear"'s absence (I think
it's not there simply because there are already too many buttons in that tab,
and a Clear Passwords button could most afford to be cut as the functionality
naturally fits next to View Passwords), but the patch is probably good enough
for now.

Comment 7

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/help/prefs.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/prefs.xhtml,v  <--  prefs.xhtml
new revision: 1.31; previous revision: 1.30
done