Closed Bug 299211 Opened 20 years ago Closed 19 years ago

whine.pl fails if derive_groups is required

Categories

(Bugzilla :: Whining, defect)

2.19.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: glob, Assigned: Wurblzap)

Details

Attachments

(1 file)

whine.pl fails if derive_groups is required, reports

"Attempted to lock a table without releasing previous lock first."

the locked tables are

whine_schedules WRITE,
whine_events READ,
profiles READ,
groups READ,
user_group_map READ

and the requested locks are

profiles WRITE,
user_group_map WRITE,
group_group_map READ,
groups READ
The solution is probably to lock those tables inside of whine.pl, and tell
Bugzilla::User that you've already locked the tables, somehow. (There's a way to
do it, as I recall.)
Version: unspecified → 2.19.3
Flags: blocking2.20?
Attached patch PatchSplinter Review
Assignee: erik → wurblzap
Status: NEW → ASSIGNED
Attachment #188344 - Flags: review?(LpSolit)
Whiteboard: [Patch awaiting review]
Target Milestone: --- → Bugzilla 2.20
Comment on attachment 188344 [details] [diff] [review]
Patch

r=LpSolit
Attachment #188344 - Flags: review?(LpSolit) → review+
Flags: approval?
Whiteboard: [Patch awaiting review] → [patch awaiting approval]
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.25; previous revision: 1.24
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.44; previous revision: 1.43
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch awaiting approval]
*** Bug 302407 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: