299212 - "already locked" errors should be more informative

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement, P3)

Description

[:glob ✱]

"already locked" errors should be more informative.

we should show the existing locks and the requested locks.

Comment 1

[Frédéric Buclin]

Looks like $self->{private_bz_tables_locked} should contain the list of tables
being locked instead of 0 or 1. Then calling Util::diff_arrays() on it and the
new tables list would immediately give you the additional tables you tried to lock.

I got this error message while adding several bugs at once to a group and this
information would help me a lot in debugging the code. Could we have it for 2.20
please? "No, we are frozen" is not an acceptable answer. :-p  If you haven't
time, I could take it.

Comment 2

[Max Kanat-Alexander]

Sure, go ahead. :-)

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Finally, I think that doing a diff between the old and new lists is less useful
than dislaying both lists completely. Indeed, having the full list will help
you to identify which lines of the code did, respectively try to do, the
locking.

Comment 4

[:glob ✱]

Comment on attachment 188294 [details] [diff] [review]
patch, v1

r=glob

Comment 5

[Frédéric Buclin]

Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.23; previous revision: 1.22
done
Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v
 <--  code-error.html.tmpl
new revision: 1.51; previous revision: 1.50
done