299223 - Windows fileinfo is very different for sunbird than firefox. please sync the two

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Henrik Gemal]

if you on windows get the fileinfo from the sunbird.exe file you get very
different info:

-- sunbird --
CompanyName=Mozilla
FileDescription=Sunbird
FileVersion=0.2b
InternalName=Sunbird
LegalCopyright=Mozilla
LegalTrademarks=Blah
OriginalFilename=sunbird.exe
ProductName=Sunbird
ProductVersion=Personal

-- firefox --
CompanyName=Mozilla
FileDescription=Firefox
FileVersion=1.0
InternalName=Firefox
LegalCopyright=Mozilla
LegalTrademarks=Firefox is a Trademark of The Mozilla Foundation.
OriginalFilename=firefox.exe
ProductName=Firefox
ProductVersion=1.8b2: 2005062906


I'd really like to get the LegalTrademarks and the ProductVersion fixed

Comment 1

[Simon Paquet [:sipaq]]

The relevant info is in mozilla/calendar/sunbird/app/module.ver

Comment 2

[Mostafa Hosseini]

Note that Sunbird is not a registered trademark so we can't claim it to be.

Comment 3

[Henrik Gemal]

The fix should be:
- make LegalTrademarks empty
- make ProductVersion display the actual version and not "Personal"

Comment 4

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 5

[Stefan Sitter [:ssitter]]

Using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060816 Calendar/0.3a2+:

LegalTrademarks = Blah
ProductVersion  = 1.9a1: 2006081606

I think Comment #2 still applies to trademark issue.

Comment 6

[Matthew (lilmatt) Willis]

Attachment: Fixes trademark text

Uses the correct language as per Frank Hecker of MoFo.

Comment 7

[Stefan Sitter [:ssitter]]

Comment on attachment 234023 [details] [diff] [review]
Fixes trademark text

r=ssitter

Comment 8

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED